Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 14347002: Adds support for 192kHz native output sample rate for WebRTC clients (Closed)

Created:
7 years, 8 months ago by henrika (OOO until Aug 14)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, DaleCurtis
Visibility:
Public.

Description

Adds support for 192kHz native output sample rate for WebRTC clients BUG=none TEST=content_unittests and manual tests using different WebRTC clients in combination with 192kHz native sample rate on Win7 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194911

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M content/renderer/media/webrtc_audio_renderer.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
henrika (OOO until Aug 14)
xians@: please check this one. It seems like ~3% of our users would benefit by ...
7 years, 8 months ago (2013-04-18 09:59:08 UTC) #1
no longer working on chromium
On 2013/04/18 09:59:08, henrika wrote: > xians@: please check this one. It seems like ~3% ...
7 years, 8 months ago (2013-04-18 10:19:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/14347002/1
7 years, 8 months ago (2013-04-18 10:58:44 UTC) #3
commit-bot: I haz the power
Change committed as 194911
7 years, 8 months ago (2013-04-18 13:21:15 UTC) #4
DaleCurtis
This may not work very well on OSX with the buffer sizes used by WebRTC ...
7 years, 8 months ago (2013-04-18 17:19:39 UTC) #5
henrika (OOO until Aug 14)
I was not able to find an output device on Mac which supported 192 but ...
7 years, 8 months ago (2013-04-18 17:53:51 UTC) #6
DaleCurtis
The buffer size for 192kHz on OSX is 512 as of a couple weeks ago. ...
7 years, 8 months ago (2013-04-18 18:28:19 UTC) #7
henrika (OOO until Aug 14)
480 is correct, i.e. FIFO from 480->512 in this case then.
7 years, 8 months ago (2013-04-18 19:01:56 UTC) #8
DaleCurtis
The shared memory doesn't block on OSX though, so we likely end up with back ...
7 years, 8 months ago (2013-04-18 19:20:40 UTC) #9
henrika (OOO until Aug 14)
7 years, 8 months ago (2013-04-18 19:44:43 UTC) #10
Message was sent while issue was closed.
I will see if we can access a Mac which can use 192 to try it out.

Powered by Google App Engine
This is Rietveld 408576698