Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1434123002: Enable theme-color on Chrome tabbed mode for phones by default. (Closed)

Created:
5 years, 1 month ago by aurimas (slooooooooow)
Modified:
5 years, 1 month ago
Reviewers:
Yusuf, gone
CC:
asvitkine+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable theme-color on Chrome tabbed mode for phones by default. - Remove about:flags enable-theme-color-in-tabbed-mode - Enable theme-color for tabbed mode for phones for all channels. BUG=482207 Committed: https://crrev.com/151479f43c58255e210c1d0f730ebf979ea360f6 Cr-Commit-Position: refs/heads/master@{#359430}

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -39 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabWebContentsObserver.java View 4 chunks +3 lines, -13 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/toolbar/BrandColorTest.java View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
aurimas (slooooooooow)
PTAL. This is in preparation to enable theme-color after chrome-launch-review gives us a GO.
5 years, 1 month ago (2015-11-11 23:49:50 UTC) #2
aurimas (slooooooooow)
Launch approved.
5 years, 1 month ago (2015-11-12 18:41:19 UTC) #3
aurimas (slooooooooow)
dfalcantara PTAL
5 years, 1 month ago (2015-11-12 21:12:32 UTC) #5
gone
lgtm
5 years, 1 month ago (2015-11-12 21:27:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1434123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1434123002/40001
5 years, 1 month ago (2015-11-12 22:40:45 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 1 month ago (2015-11-12 23:23:17 UTC) #12
commit-bot: I haz the power
5 years, 1 month ago (2015-11-12 23:24:13 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/151479f43c58255e210c1d0f730ebf979ea360f6
Cr-Commit-Position: refs/heads/master@{#359430}

Powered by Google App Engine
This is Rietveld 408576698