Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14340003: Rename AuthType to Origin of destination. (Closed)

Created:
7 years, 8 months ago by Vitaly Buka (NO REVIEWS)
Modified:
7 years, 8 months ago
Reviewers:
gene, Toscano
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Rename AuthType to Origin of destination. Store AuthType in AppState. Current Destination.Type is more suitable for selecting display styles. Origin represents better how we get this destination. BUG=179229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195151

Patch Set 1 : #

Patch Set 2 : Rename AuthType to Origin. #

Total comments: 8

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -60 lines) Patch
M chrome/browser/resources/print_preview/cloud_print_interface.js View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/print_preview/data/app_state.js View 1 2 6 chunks +20 lines, -13 lines 0 comments Download
M chrome/browser/resources/print_preview/data/cloud_parsers.js View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination.js View 1 2 6 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/resources/print_preview/data/destination_store.js View 1 2 3 14 chunks +77 lines, -27 lines 0 comments Download
M chrome/browser/resources/print_preview/data/local_parsers.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/print_preview/native_layer.js View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-18 09:52:23 UTC) #1
Vitaly Buka (NO REVIEWS)
After uploading the first patch I realized that if we call that property as "origin" ...
7 years, 8 months ago (2013-04-18 10:22:22 UTC) #2
Toscano
https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/app_state.js File chrome/browser/resources/print_preview/data/app_state.js (right): https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/app_state.js#newcode198 chrome/browser/resources/print_preview/data/app_state.js:198: if (state[AppState.Field_.VERSION] == AppState.VERSION_) { You'll have to handle ...
7 years, 8 months ago (2013-04-18 19:26:41 UTC) #3
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/app_state.js File chrome/browser/resources/print_preview/data/app_state.js (right): https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/app_state.js#newcode198 chrome/browser/resources/print_preview/data/app_state.js:198: if (state[AppState.Field_.VERSION] == AppState.VERSION_) { On 2013/04/18 19:26:41, Toscano ...
7 years, 8 months ago (2013-04-18 20:48:23 UTC) #4
Vitaly Buka (NO REVIEWS)
7 years, 8 months ago (2013-04-18 20:54:04 UTC) #5
Toscano
https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/destination_store.js#newcode649 chrome/browser/resources/print_preview/data/destination_store.js:649: return origin + '/' + id; SGTM https://codereview.chromium.org/14340003/diff/25003/chrome/browser/resources/print_preview/data/app_state.js File ...
7 years, 8 months ago (2013-04-18 22:45:40 UTC) #6
Vitaly Buka (NO REVIEWS)
https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/destination_store.js File chrome/browser/resources/print_preview/data/destination_store.js (right): https://codereview.chromium.org/14340003/diff/11001/chrome/browser/resources/print_preview/data/destination_store.js#newcode395 chrome/browser/resources/print_preview/data/destination_store.js:395: this.insertDestination(destination); On 2013/04/18 20:48:23, Vitaly Buka wrote: > Probably ...
7 years, 8 months ago (2013-04-18 23:44:59 UTC) #7
gene
lgtm, but double check with Robert
7 years, 8 months ago (2013-04-18 23:56:57 UTC) #8
Vitaly Buka (NO REVIEWS)
On 2013/04/18 23:56:57, gene wrote: > lgtm, but double check with Robert We just discussed ...
7 years, 8 months ago (2013-04-19 02:35:02 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14340003/52003
7 years, 8 months ago (2013-04-19 02:35:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14340003/52003
7 years, 8 months ago (2013-04-19 04:43:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14340003/52003
7 years, 8 months ago (2013-04-19 08:57:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14340003/52003
7 years, 8 months ago (2013-04-19 09:02:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/14340003/52003
7 years, 8 months ago (2013-04-19 09:09:34 UTC) #14
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:07:21 UTC) #15
Message was sent while issue was closed. 
Change committed as 195151

Powered by Google App Engine
This is Rietveld 408576698