Mac Plugins: Remove PluginProcessHost dtor check that it is on the UI thread.

Mac Plugins: Remove PluginProcessHost dtor check that it is on the UI thread.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195435

[Lei Zhang, 2013-04-18 04:53:42]

I don't think PluginProcessHost is ever deleted on the UI thread? Correct me if
I'm wrong.

This was added a long time ago in r28690 and most of the original folks have
moved on.

[Avi (use Gerrit), 2013-04-18 14:42:52]

I have no idea. The experts have moved on, but perhaps they have thoughts about
this.

[Lei Zhang, 2013-04-18 19:32:14]

All the places that delete PluginProcessHost, which is a
BrowserChildProcessHostDelegate in
content/browser/browser_child_process_host_impl.cc seems to happen on the IO
thread. I can add a DCHECK in ~PluginProcessHost if that helps.

[Avi (use Gerrit), 2013-04-18 19:36:55]

On 2013/04/18 19:32:14, Lei Zhang wrote:
> All the places that delete PluginProcessHost, which is a
> BrowserChildProcessHostDelegate in
> content/browser/browser_child_process_host_impl.cc seems to happen on the IO
> thread. I can add a DCHECK in ~PluginProcessHost if that helps.

LGTM with a DCHECK.

[Lei Zhang, 2013-04-18 20:12:47]

On 2013/04/18 19:36:55, Avi wrote:
> On 2013/04/18 19:32:14, Lei Zhang wrote:
> > All the places that delete PluginProcessHost, which is a
> > BrowserChildProcessHostDelegate in
> > content/browser/browser_child_process_host_impl.cc seems to happen on the IO
> > thread. I can add a DCHECK in ~PluginProcessHost if that helps.
> 
> LGTM with a DCHECK.

Done.

[commit-bot: I haz the power, 2013-04-19 22:07:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/14339002/3002

[commit-bot: I haz the power, 2013-04-19 23:26:51]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...

[commit-bot: I haz the power, 2013-04-22 01:47:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/14339002/3002

[commit-bot: I haz the power, 2013-04-22 03:43:20]

Change committed as 195435