Issue 14336003: Move MMap to SkData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14336003: Move MMap to SkData. (Closed)

Created:
7 years, 8 months ago by bungeman-skia

Modified:
7 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Move MMap to SkData. Committed: http://code.google.com/p/skia/source/detail?r=8848

Patch Set 2 : Remove unwanted change. #

Patch Set 3 : Make setting error messages a TODO. #

Patch Set 4 : Remove another unneeded change. #

Patch Set 5 : Work on Linux. #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -65 lines)			Patch
M	gm/factory.cpp	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	include/core/SkData.h	View		2 chunks	+7 lines, -3 lines	0 comments	Download
M	src/core/SkData.cpp	View	1 2 3 4	3 chunks	+88 lines, -14 lines	0 comments	Download
M	src/core/SkStream.cpp	View		2 chunks	+10 lines, -42 lines	1 comment	Download
M	src/ports/SkOSFile_stdio.cpp	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/utils/win/SkHRESULT.cpp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

Moves memory mapped files to SkData. This seems a bit cleaner, and also simplifies another ...

7 years, 8 months ago (2013-04-24 17:59:26 UTC) #1

reed1

lgtm https://codereview.chromium.org/14336003/diff/1018/src/core/SkStream.cpp File src/core/SkStream.cpp (right): https://codereview.chromium.org/14336003/diff/1018/src/core/SkStream.cpp#newcode792 src/core/SkStream.cpp:792: static SkData* mmap_filename(const char path[]) { A nice ...

7 years, 8 months ago (2013-04-24 19:07:49 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bungeman@google.com/14336003/1018

7 years, 8 months ago (2013-04-24 19:56:20 UTC) #3

Message was sent while issue was closed.

Change committed as 8848