Issue 14335005: Pepper: Autogenerate thunk for PPB_Graphics2D.

Issue 14335005: Pepper: Autogenerate thunk for PPB_Graphics2D. (Closed)

Created:
7 years, 8 months ago by teravest

Modified:
7 years, 7 months ago

Reviewers:
dmichael (off chromium)

CC:
chromium-reviews, yusukes+watch_chromium.org, jam, yzshen+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Pepper: Autogenerate thunk for PPB_Graphics2D. This change fixes a typo in the IDL, and cleans up the API a little bit so we can generate a thunk for it. The implementation in webkit is vestigal and was removed. Tested: browser_tests --gtest_filter="*Graphics2D*" BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197409

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased (file deletions in another commit) #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -82 lines)			Patch
M	content/renderer/pepper/pepper_in_process_resource_creation.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/renderer/pepper/pepper_in_process_resource_creation.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/api/dev/ppb_graphics_2d_dev.idl	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	ppapi/api/ppb_graphics_2d.idl	View		2 chunks	+4 lines, -1 line	0 comments	Download
M	ppapi/c/ppb_graphics_2d.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c	View	1	4 chunks	+6 lines, -6 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/proxy/graphics_2d_resource.h	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/graphics_2d_resource.cc	View		1 chunk	+4 lines, -9 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/thunk/ppb_graphics_2d_api.h	View		1 chunk	+4 lines, -13 lines	0 comments	Download
A	ppapi/thunk/ppb_graphics_2d_dev_thunk.cc	View		1 chunk	+49 lines, -0 lines	0 comments	Download
M	ppapi/thunk/ppb_graphics_2d_thunk.cc	View		5 chunks	+41 lines, -40 lines	0 comments	Download
M	ppapi/thunk/resource_creation_api.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dmichael (off chromium)

lgtm https://codereview.chromium.org/14335005/diff/1/ppapi/thunk/ppb_graphics_2d_dev_thunk.cc File ppapi/thunk/ppb_graphics_2d_dev_thunk.cc (right): https://codereview.chromium.org/14335005/diff/1/ppapi/thunk/ppb_graphics_2d_dev_thunk.cc#newcode1 ppapi/thunk/ppb_graphics_2d_dev_thunk.cc:1: // Copyright (c) 2012 The Chromium Authors. All ...

7 years, 8 months ago (2013-04-26 19:30:26 UTC) #2

teravest

On Fri, Apr 26, 2013 at 1:30 PM, <dmichael@chromium.org> wrote: > lgtm > > > ...

7 years, 8 months ago (2013-04-26 19:36:17 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/14335005/6001

7 years, 7 months ago (2013-04-29 17:56:02 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 7 months ago (2013-04-29 17:58:08 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/14335005/6001

7 years, 7 months ago (2013-04-30 17:18:34 UTC) #6

Message was sent while issue was closed.

Change committed as 197409

Expand Messages | Collapse Messages