Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 14331002: views: Remove SetHighlightColor usages. (Closed)

Created:
7 years, 8 months ago by tfarina
Modified:
7 years, 8 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

views: Remove SetHighlightColor usages. This seems to be equivalent to SetHoverColor and LabelButton doesn't have/implement this concept. So to make the life easier just remove it. BUG=155363 R=msw@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195038

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/ui/views/infobars/infobar_view.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/one_click_signin_infobar.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/views/message_center_view.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
7 years, 8 months ago (2013-04-18 00:11:53 UTC) #1
msw
LGTM. This color is actually the "halo_color" sent to DrawStringWithHalo. Still, it doesn't actually show ...
7 years, 8 months ago (2013-04-18 03:48:32 UTC) #2
tfarina
+mukai -> ui/message_center +pkasting -> infobars
7 years, 8 months ago (2013-04-18 11:25:37 UTC) #3
Peter Kasting
infobars LGTM
7 years, 8 months ago (2013-04-18 20:12:11 UTC) #4
Jun Mukai
lgtm
7 years, 8 months ago (2013-04-18 20:35:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14331002/1
7 years, 8 months ago (2013-04-18 21:12:31 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136550
7 years, 8 months ago (2013-04-18 22:56:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/14331002/1
7 years, 8 months ago (2013-04-18 22:59:17 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 01:08:56 UTC) #9
Message was sent while issue was closed.
Change committed as 195038

Powered by Google App Engine
This is Rietveld 408576698