Issue 14330009: Remove WebNode parameter from decidePolicyForNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14330009: Remove WebNode parameter from decidePolicyForNavigation (Closed)

Created:
7 years, 8 months ago by jamesr

Modified:
7 years, 8 months ago

Reviewers:
darin (slow to review), Nate Chapin

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove WebNode parameter from decidePolicyForNavigation This prepares for removing the WebNode originating_node parameter from WebFrameLoader::decidePolicyForNavigation() by adding overrides that don't use the parameter. After Blink moves over to calling the node-less version of these functions and is rolled into Chromium, the WebNode overrides can be deleted. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195211

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -16 lines)			Patch
M	content/renderer/render_view_browsertest.cc	View	7 chunks	+0 lines, -7 lines	0 comments	Download
M	content/renderer/render_view_impl.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	2 chunks	+11 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

jamesr

First side of Blink changes here:https://codereview.chromium.org/14328011/ Pt 2: https://codereview.chromium.org/14328011/

7 years, 8 months ago (2013-04-17 21:11:02 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/14330009/1

7 years, 8 months ago (2013-04-19 01:25:57 UTC) #4

Message was sent while issue was closed.

Change committed as 195211

Expand Messages | Collapse Messages