Issue 14329024: [DevTools] Close drawer on blur after short timeout.

Issue 14329024: [DevTools] Close drawer on blur after short timeout. (Closed)

Created:
7 years, 8 months ago by Dmitry Zvorygin

Modified:
7 years, 4 months ago

Reviewers:

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[DevTools] Close drawer in overlay mode on blur after short timeout. BUG=227732

Patch Set 1 #

Patch Set 2 : Close drawer only in overlay mode. #

Total comments: 8

Patch Set 3 : Fixed comments. #

Total comments: 1

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -8 lines)			Patch
M	Source/devtools/front_end/AdvancedSearchController.js	View	1 2	2 chunks	+3 lines, -0 lines	1 comment	Download
M	Source/devtools/front_end/DefaultTextEditor.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/Drawer.js	View	1 2	3 chunks	+24 lines, -1 line	0 comments	Download
M	Source/devtools/front_end/NavigatorView.js	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/ScriptsPanel.js	View	1 2	2 chunks	+6 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/inspector.html	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/inspector.js	View	1 2	1 chunk	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pfeldman

https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js File Source/devtools/front_end/AdvancedSearchController.js (right): https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js#newcode517 Source/devtools/front_end/AdvancedSearchController.js:517: anchor.silent = true; Clicking a link does not result ...

7 years, 8 months ago (2013-04-27 08:05:45 UTC) #2

lushnikov

https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js File Source/devtools/front_end/AdvancedSearchController.js (right): https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js#newcode613 Source/devtools/front_end/AdvancedSearchController.js:613: return true; Could you please annotate return value?

7 years, 7 months ago (2013-04-28 13:36:59 UTC) #3

Dmitry Zvorygin

Please take a look again. https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js File Source/devtools/front_end/AdvancedSearchController.js (right): https://codereview.chromium.org/14329024/diff/2001/Source/devtools/front_end/AdvancedSearchController.js#newcode517 Source/devtools/front_end/AdvancedSearchController.js:517: anchor.silent = true; On ...

7 years, 7 months ago (2013-04-29 16:02:34 UTC) #4

vsevik

https://chromiumcodereview.appspot.com/14329024/diff/10001/Source/devtools/front_end/AdvancedSearchController.js File Source/devtools/front_end/AdvancedSearchController.js (right): https://chromiumcodereview.appspot.com/14329024/diff/10001/Source/devtools/front_end/AdvancedSearchController.js#newcode517 Source/devtools/front_end/AdvancedSearchController.js:517: anchor.omitFocus = true; As discussed I don't think we ...

7 years, 7 months ago (2013-05-08 12:12:57 UTC) #5

Dmitry Zvorygin

7 years, 6 months ago (2013-05-29 14:22:47 UTC) #7

On 2013/05/29 14:13:16, pfeldman wrote:
> are we closing it as do not fix? (3 weeks)

This was waiting for your return, and I investigate option to scroll source
panel below last line as in Sublime. As we discussed with you earlier.

Expand Messages | Collapse Messages