Implementing uploading of a WebRTC diagnostic log.

content/browser/renderer_host/media/webrtc_logging_handler_host.h

Index: content/browser/renderer_host/media/webrtc_logging_handler_host.h
diff --git a/content/browser/renderer_host/media/webrtc_logging_handler_host.h b/content/browser/renderer_host/media/webrtc_logging_handler_host.h
index f3ab4a495ae9defac7a892e18338ffe5eac2c8e3..eb17a69b97438e67bfda8d659e0d4a98952ba17f 100644
--- a/content/browser/renderer_host/media/webrtc_logging_handler_host.h
+++ b/content/browser/renderer_host/media/webrtc_logging_handler_host.h
@@ -6,19 +6,26 @@
 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
 
 #include "base/basictypes.h"
-#include "base/shared_memory.h"
 #include "content/public/browser/browser_message_filter.h"
 
+namespace base {
+class SharedMemory;
+}

[tommi (sloooow) - chröme, 2013/05/16 12:06:49]

nit:
}  // base

[Henrik Grunell, 2013/05/24 13:01:51]

Done.

+
 namespace content {
 
 // WebRtcLoggingHandlerHost handles operations regarding the WebRTC logging:
-// opening and closing shared memory buffer that the handler in the renderer
-// process writes to.
+// - Opens a shared memory buffer that the handler in the render process
+//   writes to.
+// - Detects when channel, i.e. renderer, is going away and triggers uploading
+//   the log.
 class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
  public:
   WebRtcLoggingHandlerHost();
 
  private:
+  virtual ~WebRtcLoggingHandlerHost();
+
   // BrowserMessageFilter implementation.
   virtual void OnChannelClosing() OVERRIDE;
   virtual void OnDestruct() const OVERRIDE;
@@ -28,11 +35,14 @@ class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
   friend class BrowserThread;
   friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;
 
-  virtual ~WebRtcLoggingHandlerHost();
-
   void OnOpenLog();
 
-  base::SharedMemory shared_memory_;
+  void OpenLogIfAllowed();
+  void DoOpenLog();
+
+  void UploadLog();
+
+  scoped_ptr<base::SharedMemory> shared_memory_;
 
   DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost);
 };