Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: content/browser/renderer_host/webrtc_logging_handler_host.h

Issue 14329020: Implementing uploading of a WebRTC diagnostic log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed pre-submit warnings/errors (including adding bzip2 to content/browser DEPS). Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/webrtc_logging_handler_host.h
diff --git a/content/browser/renderer_host/webrtc_logging_handler_host.h b/content/browser/renderer_host/webrtc_logging_handler_host.h
index 3b4292cfc53ba90f35265b32f284e1cc809ef4bd..d0236ebd798e14737462a329c70c80f50672ea39 100644
--- a/content/browser/renderer_host/webrtc_logging_handler_host.h
+++ b/content/browser/renderer_host/webrtc_logging_handler_host.h
@@ -6,9 +6,13 @@
#define CONTENT_BROWSER_RENDERER_HOST_WEBRTC_LOGGING_HANDLER_HOST_H_
#include "base/basictypes.h"
-#include "base/shared_memory.h"
+#include "base/platform_file.h"
#include "content/public/browser/browser_message_filter.h"
+namespace base {
+class SharedMemory;
+}
+
namespace content {
// WebRtcLoggingHandlerHost handles operations regarding the WebRTC logging:
@@ -19,6 +23,8 @@ class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
WebRtcLoggingHandlerHost();
private:
+ virtual ~WebRtcLoggingHandlerHost();
+
// BrowserMessageFilter implementation.
virtual void OnChannelClosing() OVERRIDE;
virtual void OnDestruct() const OVERRIDE;
@@ -28,11 +34,16 @@ class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
friend class BrowserThread;
friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;
- virtual ~WebRtcLoggingHandlerHost();
-
void OnOpenLog();
- base::SharedMemory shared_memory_;
+ void CreateWebRtcLogFile();
+ void FinishOpenLog();
+
+ bool IsUploadingEnabled();
+ void UploadLog();
+
+ base::SharedMemory* shared_memory_;
+ base::PlatformFile log_file_compressed_;
DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost);
};

Powered by Google App Engine
This is Rietveld 408576698