Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1395)

Unified Diff: content/browser/renderer_host/media/webrtc_logging_handler_host.h

Issue 14329020: Implementing uploading of a WebRTC diagnostic log. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Code review. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/webrtc_logging_handler_host.h
diff --git a/content/browser/renderer_host/media/webrtc_logging_handler_host.h b/content/browser/renderer_host/media/webrtc_logging_handler_host.h
index f3ab4a495ae9defac7a892e18338ffe5eac2c8e3..a2b4c70e94be4e93040ec943a7480337671271d2 100644
--- a/content/browser/renderer_host/media/webrtc_logging_handler_host.h
+++ b/content/browser/renderer_host/media/webrtc_logging_handler_host.h
@@ -6,19 +6,26 @@
#define CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
#include "base/basictypes.h"
-#include "base/shared_memory.h"
#include "content/public/browser/browser_message_filter.h"
+namespace base {
+class SharedMemory;
+}
+
namespace content {
// WebRtcLoggingHandlerHost handles operations regarding the WebRTC logging:
-// opening and closing shared memory buffer that the handler in the renderer
-// process writes to.
+// - Opens a shared memory buffer that the handler in the render process
+// writes to.
+// - Detects when channel, i.e. renderer, is going away and triggers uploading
+// the log.
class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
public:
WebRtcLoggingHandlerHost();
private:
+ virtual ~WebRtcLoggingHandlerHost();
+
// BrowserMessageFilter implementation.
virtual void OnChannelClosing() OVERRIDE;
virtual void OnDestruct() const OVERRIDE;
@@ -28,11 +35,14 @@ class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
friend class BrowserThread;
friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;
- virtual ~WebRtcLoggingHandlerHost();
-
void OnOpenLog();
- base::SharedMemory shared_memory_;
+ void CheckLoggingAllowed();
+ void DoOpenLog();
+
+ void UploadLog();
+
+ scoped_ptr<base::SharedMemory> shared_memory_;
DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost);
};

Powered by Google App Engine
This is Rietveld 408576698