Implementing uploading of a WebRTC diagnostic log.

content/browser/renderer_host/media/webrtc_logging_handler_host.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

[Jói, 2013/05/24 21:14:06]

Looks like this file still needs to be rebased against the moved version in
another (pending) change.  I'll wait to do the final review until that happens,
but am still looking at all files now.

[Henrik Grunell, 2013/05/27 13:00:32]

Yes, now when it's been decided we'll move them, I'll rebase onto that. I'll do
that in a separate patch.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
 #define CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_
 
 #include "base/basictypes.h"
-#include "base/shared_memory.h"
 #include "content/public/browser/browser_message_filter.h"
 
+namespace base {
+class SharedMemory;
+}  // namespace base
+
 namespace content {
 
+class RenderProcessHost;
+
 // WebRtcLoggingHandlerHost handles operations regarding the WebRTC logging:
-// opening and closing shared memory buffer that the handler in the renderer
-// process writes to.
+// - Opens a shared memory buffer that the handler in the render process
+//   writes to.
+// - Detects when channel, i.e. renderer, is going away and triggers uploading
+//   the log.
 class WebRtcLoggingHandlerHost : public BrowserMessageFilter {
  public:
-  WebRtcLoggingHandlerHost();
+  WebRtcLoggingHandlerHost(RenderProcessHost* render_process_host);
 
  private:
+  friend class BrowserThread;
+  friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;
+
+  virtual ~WebRtcLoggingHandlerHost();
+
   // BrowserMessageFilter implementation.
   virtual void OnChannelClosing() OVERRIDE;
   virtual void OnDestruct() const OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& message,
                                  bool* message_was_ok) OVERRIDE;
 
-  friend class BrowserThread;
-  friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;
+  void OnOpenLog(const std::string& app_session_id,  const std::string& app_url);

[Jói, 2013/05/24 21:14:06]

+80

[Henrik Grunell, 2013/05/27 13:00:32]

Done.

 
-  virtual ~WebRtcLoggingHandlerHost();
+  void OpenLogIfAllowed();
+  void DoOpenLog();
 
-  void OnOpenLog(const std::string& app_session_id, const std::string& app_url);
+  void UploadLog();
 
-  base::SharedMemory shared_memory_;
+  RenderProcessHost* render_process_host_;
+  scoped_ptr<base::SharedMemory> shared_memory_;
   std::string app_session_id_;
   std::string app_url_;
 
   DISALLOW_COPY_AND_ASSIGN(WebRtcLoggingHandlerHost);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_MEDIA_WEBRTC_LOGGING_HANDLER_HOST_H_