Chrome OS device policy for Variations Restrict Parameter.

Add a Chrome OS device policy for Variations Restrict Parameter, called DeviceVariationsRestrictParameter.

Made previous VariationsRestrictParameter policy exclude Chrome OS.

CL based on https://codereview.chromium.org/12728009/

BUG=232881
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194963

[Mattias Nissler (ping if slow), 2013-04-17 17:36:50]

LGTM with nits and pending green tryjobs. Please do consider adding a browser
test as well.

https://codereview.chromium.org/14329002/diff/1/chrome/app/policy/policy_temp...
File chrome/app/policy/policy_templates.json (right):

https://codereview.chromium.org/14329002/diff/1/chrome/app/policy/policy_temp...
chrome/app/policy/policy_templates.json:4509: 'dynamic_refresh': True,
You actually don't do dynamic_refresh as long as you don't pick up changes to
the policy at runtime. Can you fix the other policy as well?

https://codereview.chromium.org/14329002/diff/1/chrome/browser/chromeos/setti...
File chrome/browser/chromeos/settings/device_settings_provider.cc (right):

https://codereview.chromium.org/14329002/diff/1/chrome/browser/chromeos/setti...
chrome/browser/chromeos/settings/device_settings_provider.cc:630:
new_values_cache->SetString(kVariationsRestrictParameter, "");
The default value is an empty string, so you can simplify this entire block to:

if (policy.has_variations_restrict_parameter()) {
  new_values_cache->SetString(
      kVariationsRestrictParameter,
      policy.variations_restrict_parameter().parameter());
}

[Mathieu, 2013-04-17 20:04:57]

Thanks Mattias. 

Not sure what browsertest you are telling me to consider. Do you mean a test for
the feature code or the policy change?

Running try bots now.

https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/app/policy/poli...
File chrome/app/policy/policy_templates.json (right):

https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/app/policy/poli...
chrome/app/policy/policy_templates.json:4509: 'dynamic_refresh': True,
On 2013/04/17 17:36:50, Mattias Nissler wrote:
> You actually don't do dynamic_refresh as long as you don't pick up changes to
> the policy at runtime. Can you fix the other policy as well?

Done.

https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/settings/device_settings_provider.cc (right):

https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/settings/device_settings_provider.cc:630:
new_values_cache->SetString(kVariationsRestrictParameter, "");
On 2013/04/17 17:36:50, Mattias Nissler wrote:
> The default value is an empty string, so you can simplify this entire block
to:
> 
> if (policy.has_variations_restrict_parameter()) {
>   new_values_cache->SetString(
>       kVariationsRestrictParameter,
>       policy.variations_restrict_parameter().parameter());
> }

Done.

[Alexei Svitkine (slow), 2013-04-17 20:43:44]

Please create a crbug.com entry for this and associate it appropriately.

[Mattias Nissler (ping if slow), 2013-04-18 10:52:11]

On 2013/04/17 20:04:57, Mathieu Perreault wrote:
> Thanks Mattias. 
> 
> Not sure what browsertest you are telling me to consider. Do you mean a test
for
> the feature code or the policy change?

Ideally, you have a browser test that sets the policy and verifies the policy
takes effect in your feature code. See
chrome/browser/policy/policy_browsertest.cc for examples. This helps making sure
that the policy doesn't break when people refactor code and are not aware of the
policy knob affecting the feature.

> 
> Running try bots now.
> 
>
https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/app/policy/poli...
> File chrome/app/policy/policy_templates.json (right):
> 
>
https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/app/policy/poli...
> chrome/app/policy/policy_templates.json:4509: 'dynamic_refresh': True,
> On 2013/04/17 17:36:50, Mattias Nissler wrote:
> > You actually don't do dynamic_refresh as long as you don't pick up changes
to
> > the policy at runtime. Can you fix the other policy as well?
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/browser/chromeo...
> File chrome/browser/chromeos/settings/device_settings_provider.cc (right):
> 
>
https://chromiumcodereview.appspot.com/14329002/diff/1/chrome/browser/chromeo...
> chrome/browser/chromeos/settings/device_settings_provider.cc:630:
> new_values_cache->SetString(kVariationsRestrictParameter, "");
> On 2013/04/17 17:36:50, Mattias Nissler wrote:
> > The default value is an empty string, so you can simplify this entire block
> to:
> > 
> > if (policy.has_variations_restrict_parameter()) {
> >   new_values_cache->SetString(
> >       kVariationsRestrictParameter,
> >       policy.variations_restrict_parameter().parameter());
> > }
> 
> Done.

[Mathieu, 2013-04-18 14:52:22]

I've created another CL to test the existing user policy code:
https://codereview.chromium.org/13831007/

The device policy browsertest will be in:
https://codereview.chromium.org/14268009/

I'll be sending this one soon.

[commit-bot: I haz the power, 2013-04-18 14:52:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mathp@chromium.org/14329002/1010

[commit-bot: I haz the power, 2013-04-18 17:43:13]

Change committed as 194963