Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Side by Side Diff: extensions/browser/service_worker_manager.cc

Issue 1432823003: Add a test to cover service worker update codepath when extension is updated (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use set_force_update_on_page_load() + git cl format Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/service_worker_manager.h" 5 #include "extensions/browser/service_worker_manager.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "content/public/browser/browser_context.h" 8 #include "content/public/browser/browser_context.h"
9 #include "content/public/browser/service_worker_context.h" 9 #include "content/public/browser/service_worker_context.h"
10 #include "content/public/browser/storage_partition.h" 10 #include "content/public/browser/storage_partition.h"
(...skipping 30 matching lines...) Expand all
41 // TODO(devlin): Technically, this can fail. We should ideally: 41 // TODO(devlin): Technically, this can fail. We should ideally:
42 // a) Keep track of extensions with registered service workers. 42 // a) Keep track of extensions with registered service workers.
43 // b) Add a callback to the (Un)SuspendServiceWorkersOnOrigin() method. 43 // b) Add a callback to the (Un)SuspendServiceWorkersOnOrigin() method.
44 // c) Check for any orphaned workers. 44 // c) Check for any orphaned workers.
45 content::BrowserContext::GetStoragePartitionForSite(browser_context_, 45 content::BrowserContext::GetStoragePartitionForSite(browser_context_,
46 extension->url()) 46 extension->url())
47 ->GetServiceWorkerContext() 47 ->GetServiceWorkerContext()
48 ->DeleteForOrigin(extension->url(), base::Bind(&EmptySuccessCallback)); 48 ->DeleteForOrigin(extension->url(), base::Bind(&EmptySuccessCallback));
49 } 49 }
50 50
51 void ServiceWorkerManager::OnExtensionWillBeInstalled(
52 content::BrowserContext* browser_context,
53 const Extension* extension,
54 bool is_update,
55 bool from_ephemeral,
56 const std::string& old_name) {
57 if (is_update) {
Devlin 2015/11/11 17:10:29 nit: A brief comment saying why we do this would p
lazyboy 2015/11/11 22:34:03 Done.
58 content::BrowserContext::GetStoragePartitionForSite(browser_context_,
59 extension->url())
60 ->GetServiceWorkerContext()
61 ->SetForceUpdateOnPageLoadForOrigin(extension->url());
62 }
63 }
64
51 } // namespace extensions 65 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698