Add a test to cover service worker update codepath when extension is updated

chrome/browser/extensions/service_worker_apitest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind_helpers.h"
 #include "base/strings/stringprintf.h"
 #include "chrome/browser/extensions/extension_apitest.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/ui_test_utils.h"
@@ skipping 114 matching lines @@
   std::string error;
   const Extension* extension =
       StartTestFromBackgroundPage("register.js", &error);
   EXPECT_EQ(
       "Failed to register a ServiceWorker: The URL protocol of the current "
       "origin ('chrome-extension://" +
           extension->id() + "') is not supported.",
       error);
 }
 
+IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, UpdateRefreshesServiceWorker) {
+  base::ScopedTempDir scoped_temp_dir;
+  ASSERT_TRUE(scoped_temp_dir.CreateUniqueTempDir());
+  base::FilePath pem_path = test_data_dir_.AppendASCII("service_worker")
+                                .AppendASCII("update")
+                                .AppendASCII("service_worker.pem");
+  base::FilePath path_v1 = PackExtensionWithOptions(
+      test_data_dir_.AppendASCII("service_worker")
+          .AppendASCII("update")
+          .AppendASCII("v1"),
+      scoped_temp_dir.path().AppendASCII("v1.crx"), pem_path, base::FilePath());
+  base::FilePath path_v2 = PackExtensionWithOptions(
+      test_data_dir_.AppendASCII("service_worker")
+          .AppendASCII("update")
+          .AppendASCII("v2"),
+      scoped_temp_dir.path().AppendASCII("v2.crx"), pem_path, base::FilePath());
+
+  ExtensionService* service =

[Devlin, 2015/11/11 17:10:29]

nit: there's an extension_service() accessor on ExtensionBrowserTest (which this
extends).

[lazyboy, 2015/11/11 22:32:23]

Not needed anymore.

+      ExtensionSystem::Get(browser()->profile())->extension_service();
+  const char kId[] = "hfaanndiiilofhfokeanhddpkfffchdi";
+
+  // Install version 1.0 of the extension.
+  ASSERT_TRUE(InstallExtension(path_v1, 1));
+  EXPECT_TRUE(service->GetExtensionById(kId, false) != NULL);

[Devlin, 2015/11/11 17:10:29]

nit: GetExtensionById is deprecated. Prefer
ExtensionRegistry::enabled_extensions().GetByID().

[lazyboy, 2015/11/11 22:32:23]

Done.

+
+  const char* kScript = "window.testResolver();";

[Devlin, 2015/11/11 17:10:29]

nitty nit: pick one between const char[] (line 154) and const char*. :)

[lazyboy, 2015/11/11 22:32:23]

Done.

+  EXPECT_EQ("true", ExecuteScriptInBackgroundPage(kId, kScript));

[Devlin, 2015/11/11 17:10:29]

This is an interesting pattern.  Usually we would use
ExtensionTestMessageListener + chrome.test.sendMessage for this type of thing,
but this is kinda nifty, so I'm fine with this approach.  My only nit would be
that I'd like to see this compare the result to "version 1" and "version 2"
explicitly - I'm just a little worried about JS's general happiness to convert
things to true/false.  (I'm sure it's fine, but peace of mind is worth a lot.
:))

[lazyboy, 2015/11/11 22:32:23]

Changed to compare with the actual received message from
SW. So, the chance of accidentally converting sth to "true"
is gone.

+
+  // Update to version 2.0.
+  EXPECT_TRUE(UpdateExtension(kId, path_v2, 0));
+  EXPECT_TRUE(service->GetExtensionById(kId, false) != NULL);
+
+  EXPECT_EQ("true", ExecuteScriptInBackgroundPage(kId, kScript));
+}
+
 IN_PROC_BROWSER_TEST_F(ServiceWorkerTest, FetchArbitraryPaths) {
   const Extension* extension =
       StartTestFromBackgroundPage("fetch.js", kExpectSuccess);
 
   // Open some arbirary paths. Their contents should be what the service worker
   // responds with, which in this case is the path of the fetch.
   EXPECT_EQ(
       "Caught a fetch for /index.html",
       NavigateAndExtractInnerText(extension->GetResourceURL("index.html")));
   EXPECT_EQ("Caught a fetch for /path/to/other.html",
@@ skipping 186 matching lines @@
 IN_PROC_BROWSER_TEST_F(ServiceWorkerTest,
                        GetBackgroundClientFailsWithNoBackgroundPage) {
   // This extension doesn't have a background page, only a tab at page.html.
   // The service worker it registers tries to call getBackgroundClient() and
   // should fail.
   // Note that this also tests that service workers can be registered from tabs.
   EXPECT_TRUE(RunExtensionSubtest("service_worker/no_background", "page.html"));
 }
 
 }  // namespace extensions