Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 14328013: QUIC - fix memory leak. (Closed)

Created:
7 years, 8 months ago by ramant (doing other things)
Modified:
7 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Deleted suppressions #

Patch Set 3 : Merging changes #

Patch Set 4 : Merging changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -18 lines) Patch
M net/quic/quic_stream_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/heapcheck/suppressions.txt View 1 2 3 1 chunk +0 lines, -8 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
7 years, 8 months ago (2013-04-17 22:30:27 UTC) #1
Derek Bruening
Can you also remove the Valgrind and Heapcheck suppressions added in r194676 as part of ...
7 years, 8 months ago (2013-04-17 23:05:57 UTC) #2
ramant (doing other things)
PTAL.
7 years, 8 months ago (2013-04-17 23:15:16 UTC) #3
Derek Bruening
LGTM
7 years, 8 months ago (2013-04-17 23:16:13 UTC) #4
Ryan Hamilton
lgtm
7 years, 8 months ago (2013-04-18 18:18:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14328013/8001
7 years, 8 months ago (2013-04-18 18:21:43 UTC) #6
commit-bot: I haz the power
Failed to apply patch for tools/heapcheck/suppressions.txt: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-18 18:21:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14328013/14001
7 years, 8 months ago (2013-04-18 18:40:59 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30302
7 years, 8 months ago (2013-04-18 22:21:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/14328013/14001
7 years, 8 months ago (2013-04-18 22:23:35 UTC) #10
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 01:01:06 UTC) #11
Message was sent while issue was closed.
Change committed as 195037

Powered by Google App Engine
This is Rietveld 408576698