Issue 14327015: app_list: Fix label misalignment after installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14327015: app_list: Fix label misalignment after installation. (Closed)

Created:
7 years, 8 months ago by xiyuan

Modified:
7 years, 8 months ago

Reviewers:
James Cook, sky

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

app_list: Fix label misalignment after installation. App item title is manually centered to avoid the default eliding at both ends behavior. As such, it needs to re-layout when the title text changes. BUG=219248 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195207

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ui/app_list/views/app_list_item_view.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

xiyuan

sky, could you take care of this one since james is sick today? Thanks.

7 years, 8 months ago (2013-04-18 16:21:26 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14327015/1

7 years, 8 months ago (2013-04-18 18:44:09 UTC) #5

commit-bot: I haz the power

Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30301

7 years, 8 months ago (2013-04-18 22:19:24 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/14327015/1

7 years, 8 months ago (2013-04-19 00:54:32 UTC) #7

Message was sent while issue was closed.

Change committed as 195207

Expand Messages | Collapse Messages