Moved some message center constants to message_center_constants.h.

Moved some message center constants to message_center_constants.h.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195077

[dharcourt, 2013-04-17 18:13:45]

These constants were moved as part of work to reduce layout sizing queries in
MessageCenterView. They were isolated to this change list to leave the
MessageCenterView change list focussed on that.

Jun, please provide an overall review.

Steven, please provide an OWNERS review of
ash/system/web_notification/web_notification_tray_unittest.cc.

Thanks!

    - Charles

[Jun Mukai, 2013-04-17 18:16:14]

lgtm

[stevenjb, 2013-04-17 22:38:01]

lgtm

[commit-bot: I haz the power, 2013-04-18 15:07:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14327004/1017

[commit-bot: I haz the power, 2013-04-18 15:07:49]

Failed to apply patch for ui/message_center/notification_list_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file ui/message_center/notification_list_unittest.cc
  Hunk #1 succeeded at 188 (offset 1 line).
  Hunk #2 FAILED at 214.
  Hunk #3 FAILED at 242.
  Hunk #4 succeeded at 387 (offset 54 lines).
  2 out of 4 hunks FAILED -- saving rejects to file
ui/message_center/notification_list_unittest.cc.rej

Patch:       ui/message_center/notification_list_unittest.cc
Index: ui/message_center/notification_list_unittest.cc
diff --git a/ui/message_center/notification_list_unittest.cc
b/ui/message_center/notification_list_unittest.cc
index
aed91619e82440a94d72c80f8801f714312e4974..71972b031fac0d970122b51e07689116f45f9360
100644
--- a/ui/message_center/notification_list_unittest.cc
+++ b/ui/message_center/notification_list_unittest.cc
@@ -187,21 +187,18 @@ TEST_F(NotificationListTest,
GetNotificationsBySourceOrExtensions) {
 
 TEST_F(NotificationListTest, OldPopupShouldNotBeHidden) {
   std::vector<std::string> ids;
-  for (size_t i = 0; i <= NotificationList::kMaxVisiblePopupNotifications;
-       i++) {
+  for (size_t i = 0; i <= kMaxVisiblePopupNotifications; i++)
     ids.push_back(AddNotification(NULL));
-  }
 
   NotificationList::PopupNotifications popups =
       notification_list()->GetPopupNotifications();
   // The popup should contain the oldest kMaxVisiblePopupNotifications. Newer
   // one should come earlier in the popup list. It means, the last element
   // of |popups| should be the firstly added one, and so on.
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications, popups.size());
+  EXPECT_EQ(kMaxVisiblePopupNotifications, popups.size());
   NotificationList::PopupNotifications::const_reverse_iterator iter =
       popups.rbegin();
-  for (size_t i = 0; i < NotificationList::kMaxVisiblePopupNotifications;
-       ++i, ++iter) {
+  for (size_t i = 0; i < kMaxVisiblePopupNotifications; ++i, ++iter) {
     EXPECT_EQ(ids[i], (*iter)->id()) << i;
   }
 
@@ -217,27 +214,25 @@ TEST_F(NotificationListTest, Priority) {
   ASSERT_EQ(0u, notification_list()->unread_count());
 
   // Default priority has the limit on the number of the popups.
-  for (size_t i = 0; i <= NotificationList::kMaxVisiblePopupNotifications;
-       ++i) {
+  for (size_t i = 0; i <= kMaxVisiblePopupNotifications; ++i)
     AddNotification(NULL);
-  }
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications + 1,
+  EXPECT_EQ(kMaxVisiblePopupNotifications + 1,
             notification_list()->NotificationCount());
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications, GetPopupCounts());
+  EXPECT_EQ(kMaxVisiblePopupNotifications, GetPopupCounts());
 
   // Low priority: not visible to popups.
   notification_list()->SetMessageCenterVisible(true);
   notification_list()->SetMessageCenterVisible(false);
   EXPECT_EQ(0u, notification_list()->unread_count());
   AddPriorityNotification(-1);
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications + 2,
+  EXPECT_EQ(kMaxVisiblePopupNotifications + 2,
             notification_list()->NotificationCount());
   EXPECT_EQ(1u, notification_list()->unread_count());
   EXPECT_EQ(0u, GetPopupCounts());
 
   // Minimum priority: doesn't update the unread count.
   AddPriorityNotification(-2);
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications + 3,
+  EXPECT_EQ(kMaxVisiblePopupNotifications + 3,
             notification_list()->NotificationCount());
   EXPECT_EQ(1u, notification_list()->unread_count());
   EXPECT_EQ(0u, GetPopupCounts());
@@ -245,18 +240,13 @@ TEST_F(NotificationListTest, Priority) {
   notification_list()->RemoveAllNotifications();
 
   // Higher priority: no limits to the number of popups.
-  for (size_t i = 0; i < NotificationList::kMaxVisiblePopupNotifications * 2;
-       ++i) {
+  for (size_t i = 0; i < kMaxVisiblePopupNotifications * 2; ++i)
     AddPriorityNotification(1);
-  }
-  for (size_t i = 0; i < NotificationList::kMaxVisiblePopupNotifications * 2;
-       ++i) {
+  for (size_t i = 0; i < kMaxVisiblePopupNotifications * 2; ++i)
     AddPriorityNotification(2);
-  }
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications * 4,
+  EXPECT_EQ(kMaxVisiblePopupNotifications * 4,
             notification_list()->NotificationCount());
-  EXPECT_EQ(NotificationList::kMaxVisiblePopupNotifications * 4,
-            GetPopupCounts());
+  EXPECT_EQ(kMaxVisiblePopupNotifications * 4, GetPopupCounts());
 }
 
 TEST_F(NotificationListTest, HasPopupsWithPriority) {
@@ -336,8 +326,7 @@ TEST_F(NotificationListTest, MarkSinglePopupAsShown) {
   std::string id2 = AddNotification(NULL);
   std::string id3 = AddNotification(NULL);
   ASSERT_EQ(3u, notification_list()->NotificationCount());
-  ASSERT_EQ(std::min(static_cast<size_t>(3u),
-                     NotificationList::kMaxVisiblePopupNotifications),
+  ASSERT_EQ(std::min(static_cast<size_t>(3u), kMaxVisiblePopupNotifications),
             GetPopupCounts());
 
   notification_list()->MarkSinglePopupAsShown(id2, true);

[commit-bot: I haz the power, 2013-04-18 18:27:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14327004/9001

[commit-bot: I haz the power, 2013-04-18 22:00:04]

Retried try job too often on win7_aura for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-04-19 00:50:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/14327004/9001

[commit-bot: I haz the power, 2013-04-19 03:40:19]

Change committed as 195077