Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 143263024: Cast: Refactoring RtpReceiver to Clang format (Closed)

Created:
6 years, 10 months ago by mikhal1
Modified:
6 years, 10 months ago
Reviewers:
hubbe
CC:
chromium-reviews, hclam+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

CAst: Refactoring RtpReceiver to Clang format This cl is pure style-targeted refactoring. No functional changes were made. BUG=339176 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248829

Patch Set 1 #

Total comments: 2

Patch Set 2 : Responding to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -97 lines) Patch
M media/cast/rtp_receiver/mock_rtp_payload_feedback.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/cast/rtp_receiver/mock_rtp_payload_feedback.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M media/cast/rtp_receiver/receiver_stats.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/cast/rtp_receiver/receiver_stats.cc View 1 3 chunks +11 lines, -8 lines 0 comments Download
M media/cast/rtp_receiver/receiver_stats_unittest.cc View 7 chunks +35 lines, -24 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/include/mock/mock_rtp_feedback.h View 1 chunk +6 lines, -8 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser.h View 1 chunk +7 lines, -4 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser.cc View 5 chunks +24 lines, -15 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/rtp_parser_unittest.cc View 5 chunks +6 lines, -9 lines 0 comments Download
M media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.h View 2 chunks +2 lines, -1 line 0 comments Download
M media/cast/rtp_receiver/rtp_parser/test/rtp_packet_builder.cc View 3 chunks +7 lines, -17 lines 0 comments Download
M media/cast/rtp_receiver/rtp_receiver.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/cast/rtp_receiver/rtp_receiver.cc View 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mikhal1
Please review, -Mikhal
6 years, 10 months ago (2014-02-03 21:43:24 UTC) #1
hubbe
LGTM (with one nit) https://chromiumcodereview.appspot.com/143263024/diff/1/media/cast/rtp_receiver/receiver_stats.cc File media/cast/rtp_receiver/receiver_stats.cc (right): https://chromiumcodereview.appspot.com/143263024/diff/1/media/cast/rtp_receiver/receiver_stats.cc#newcode48 media/cast/rtp_receiver/receiver_stats.cc:48: (256 * This is pretty ...
6 years, 10 months ago (2014-02-03 21:49:35 UTC) #2
mikhal1
https://chromiumcodereview.appspot.com/143263024/diff/1/media/cast/rtp_receiver/receiver_stats.cc File media/cast/rtp_receiver/receiver_stats.cc (right): https://chromiumcodereview.appspot.com/143263024/diff/1/media/cast/rtp_receiver/receiver_stats.cc#newcode48 media/cast/rtp_receiver/receiver_stats.cc:48: (256 * On 2014/02/03 21:49:36, hubbe wrote: > This ...
6 years, 10 months ago (2014-02-04 00:16:26 UTC) #3
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-02-04 00:16:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/143263024/100001
6 years, 10 months ago (2014-02-04 00:19:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 03:55:24 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=256086
6 years, 10 months ago (2014-02-04 03:55:25 UTC) #7
mikhal1
The CQ bit was checked by mikhal@chromium.org
6 years, 10 months ago (2014-02-04 21:03:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/143263024/100001
6 years, 10 months ago (2014-02-04 22:26:45 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/143263024/100001
6 years, 10 months ago (2014-02-05 01:02:25 UTC) #10
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 02:05:14 UTC) #11
Message was sent while issue was closed. 
Change committed as 248829

Powered by Google App Engine
This is Rietveld 408576698