Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Unified Diff: runtime/vm/os_macos.cc

Issue 1432603002: Return correct ActivationFrameAlignment for iOS simulator variants (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/os_macos.cc
diff --git a/runtime/vm/os_macos.cc b/runtime/vm/os_macos.cc
index a7d3ee672364ef5fedf66fbb956ddf1a5bd1e546..1a9537e82bd8d92fa2c6f41364c63994213172bb 100644
--- a/runtime/vm/os_macos.cc
+++ b/runtime/vm/os_macos.cc
@@ -149,6 +149,10 @@ intptr_t OS::ActivationFrameAlignment() {
return 8;
#elif TARGET_ARCH_ARM64
return 16;
+#else
rmacnak 2015/11/03 21:13:00 Let's avoid fall through. #elif TARGET_ARCH_IA32
+ // If the target is iOS but arch not one of ARM or ARM64, this is a simulator
+ // build
+ return 16;
#endif
#else // TARGET_OS_IOS
// OS X activation frames must be 16 byte-aligned; see "Mac OS X ABI
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698