Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 14326003: Prevent Chrome from crashing if a tab is closed while the media settings bubble is opea and a setti… (Closed)

Created:
7 years, 8 months ago by markusheintz_
Modified:
7 years, 8 months ago
Reviewers:
xians
CC:
chromium-reviews, Henrik Grunell
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Prevent Chrome from crashing if a tab is closed while the media settings bubble is opea and a settings was changed.n BUG=173204 TEST=(1) Visit apprtc.appspot.com and allow the website to capture you mic and cam. (2) Click on the camera icon on the right side of the omnibox to open the media settings bubble. (3) Change the media settings to block, but don't close the bubble (4) Close the tab with the open bubble (5) Verify that Chrome does not crash. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/content_settings/content_setting_bubble_model.cc View 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
markusheintz_
cc Henrik FYI Hey Shijing sine you are familiar with the issue could you please ...
7 years, 8 months ago (2013-04-18 09:24:10 UTC) #1
no longer working on chromium
lgtm, thanks for fixing it. Should we merge it to M26 if possible? SX
7 years, 8 months ago (2013-04-18 09:34:22 UTC) #2
markusheintz_
On 2013/04/18 09:34:22, xians1 wrote: > lgtm, thanks for fixing it. Should we merge it ...
7 years, 8 months ago (2013-04-18 09:47:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/14326003/1
7 years, 8 months ago (2013-04-18 09:48:10 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=136162
7 years, 8 months ago (2013-04-18 12:12:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/markusheintz@chromium.org/14326003/1
7 years, 8 months ago (2013-04-18 13:06:37 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 14:27:46 UTC) #7
Message was sent while issue was closed.
Change committed as 194918

Powered by Google App Engine
This is Rietveld 408576698