Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: chrome/browser/ui/webui/options/managed_user_settings_handler.cc

Issue 14325003: Clean up managed user settings dialogs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix broken merge Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/options/managed_user_settings_handler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/options/managed_user_settings_handler.cc
diff --git a/chrome/browser/ui/webui/options/managed_user_settings_handler.cc b/chrome/browser/ui/webui/options/managed_user_settings_handler.cc
index 8d07789d97aff27d6ea588a1386fac41523d3088..6b420d00d9d5868f0e6afea8005579c960e5e601 100644
--- a/chrome/browser/ui/webui/options/managed_user_settings_handler.cc
+++ b/chrome/browser/ui/webui/options/managed_user_settings_handler.cc
@@ -98,30 +98,12 @@ ManagedUserSettingsHandler::ManagedUserSettingsHandler()
ManagedUserSettingsHandler::~ManagedUserSettingsHandler() {
}
-void ManagedUserSettingsHandler::InitializeHandler() {
- pref_change_registrar_.Init(Profile::FromWebUI(web_ui())->GetPrefs());
- pref_change_registrar_.Add(
- prefs::kManagedModeLocalPassphrase,
- base::Bind(&ManagedUserSettingsHandler::OnLocalPassphraseChanged,
- base::Unretained(this)));
-}
-
void ManagedUserSettingsHandler::InitializePage() {
if (!CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableManagedUsers)) {
return;
}
-#if !defined(OS_CHROMEOS)
- PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
- bool passphrase_empty =
- pref_service->GetString(prefs::kManagedModeLocalPassphrase).empty();
- base::FundamentalValue is_passphrase_set(!passphrase_empty);
- web_ui()->CallJavascriptFunction(
- "ManagedUserSettings.passphraseChanged",
- is_passphrase_set);
-#endif
-
// Populate the list.
UpdateViewFromModel();
}
@@ -146,7 +128,7 @@ void ManagedUserSettingsHandler::HandlePageOpened(const base::ListValue* args) {
}
if (observer->is_elevated()) {
- web_ui()->CallJavascriptFunction("ManagedUserSettings.isAuthenticated",
+ web_ui()->CallJavascriptFunction("ManagedUserSettings.setAuthenticated",
base::FundamentalValue(true));
}
}
@@ -180,10 +162,7 @@ void ManagedUserSettingsHandler::GetLocalizedValues(
// Other managed user settings
{ "advancedManagedUserSettings", IDS_ADVANCED_MANAGED_USER_LABEL },
{ "enableSafeSearch", IDS_SAFE_SEARCH_ENABLED },
- { "allowSignIn", IDS_SIGNIN_SYNC_ALLOWED },
- { "disableHistoryDeletion", IDS_HISTORY_DELETION_DISABLED },
- { "usePassphrase", IDS_USE_PASSPHRASE_LABEL },
- { "setPassphrase", IDS_SET_PASSPHRASE_BUTTON }
+ { "setPassphrase", IDS_SET_PASSPHRASE_BUTTON },
};
RegisterStrings(localized_strings, resources, arraysize(resources));
@@ -206,15 +185,17 @@ void ManagedUserSettingsHandler::RegisterMessages() {
"settingsPageOpened",
base::Bind(&ManagedUserSettingsHandler::HandlePageOpened,
base::Unretained(this)));
- web_ui()->RegisterMessageCallback("removeManualException",
+ web_ui()->RegisterMessageCallback(
+ "removeManualException",
base::Bind(&ManagedUserSettingsHandler::RemoveManualException,
base::Unretained(this)));
- web_ui()->RegisterMessageCallback("setManualException",
+ web_ui()->RegisterMessageCallback(
+ "setManualException",
base::Bind(&ManagedUserSettingsHandler::SetManualException,
base::Unretained(this)));
- web_ui()->RegisterMessageCallback("checkManualExceptionValidity",
- base::Bind(
- &ManagedUserSettingsHandler::CheckManualExceptionValidity,
+ web_ui()->RegisterMessageCallback(
+ "checkManualExceptionValidity",
+ base::Bind(&ManagedUserSettingsHandler::CheckManualExceptionValidity,
base::Unretained(this)));
}
@@ -229,14 +210,6 @@ void ManagedUserSettingsHandler::SaveMetrics(const ListValue* args) {
}
}
-void ManagedUserSettingsHandler::OnLocalPassphraseChanged() {
- PrefService* pref_service = Profile::FromWebUI(web_ui())->GetPrefs();
- base::FundamentalValue is_passphrase_set(!pref_service->GetString(
- prefs::kManagedModeLocalPassphrase).empty());
- web_ui()->CallJavascriptFunction("ManagedUserSettings.passphraseChanged",
- is_passphrase_set);
-}
-
void ManagedUserSettingsHandler::RemoveManualException(
const ListValue* args) {
// Check if the user is authenticated.
« no previous file with comments | « chrome/browser/ui/webui/options/managed_user_settings_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698