Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 14325003: Clean up managed user settings dialogs. (Closed)

Created:
7 years, 8 months ago by Bernhard Bauer
Modified:
7 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, dbeam+watch-options_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Clean up managed user settings dialogs: * Remove options which won't be configurable * Allow empty passphrases * Use WebUI stylesheet in passphrase dialog * JS style cleanup. BUG=231909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194922

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Patch Set 5 : . #

Patch Set 6 : sync #

Patch Set 7 : fix broken merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -247 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/managed_user_passphrase_dialog.css View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/resources/managed_user_passphrase_dialog.html View 3 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/managed_user_exceptions_area.js View 1 2 3 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/managed_user_set_passphrase.html View 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/options/managed_user_set_passphrase.js View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/managed_user_settings.html View 1 2 3 4 5 4 chunks +12 lines, -45 lines 0 comments Download
M chrome/browser/resources/options/managed_user_settings.js View 1 2 3 4 5 6 6 chunks +49 lines, -85 lines 0 comments Download
M chrome/browser/ui/webui/managed_user_passphrase_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/managed_user_passphrase_handler.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_passphrase_handler.cc View 1 2 3 4 5 2 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_set_passphrase_browsertest.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/managed_user_settings_browsertest.js View 1 2 2 chunks +2 lines, -18 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_settings_handler.h View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/managed_user_settings_handler.cc View 1 2 3 4 5 5 chunks +9 lines, -36 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bernhard Bauer
Evan, you're the lucky winner of today's OWNERS roulette! Please review :)
7 years, 8 months ago (2013-04-17 18:07:46 UTC) #1
Evan Stade
lgtm
7 years, 8 months ago (2013-04-18 02:31:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/14325003/19001
7 years, 8 months ago (2013-04-18 12:33:06 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/options/managed_user_settings.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 8 months ago (2013-04-18 12:33:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/14325003/21002
7 years, 8 months ago (2013-04-18 12:40:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/14325003/20017
7 years, 8 months ago (2013-04-18 12:54:56 UTC) #6
commit-bot: I haz the power
7 years, 8 months ago (2013-04-18 15:02:17 UTC) #7
Message was sent while issue was closed.
Change committed as 194922

Powered by Google App Engine
This is Rietveld 408576698