Pass information to ppapi plugin if a mouse button was pressed during MouseMove event. This patch r…

Pass information to ppapi plugin if a mouse button was pressed during MouseMove event. This patch requiers a separate patch I submitted to blink.

BUG=179054
TEST=Load the 2d or input example plugins and try to draw in them.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195444

[yael.aharon, 2013-04-18 20:57:04]

This patch is associated with  https://codereview.chromium.org/14031008/. Please
review them together.

[dmichael (off chromium), 2013-04-18 22:32:19]

Thanks for contributing!

There's a small chance this could break apps that only look for a button to be
set but don't actually check for MOUSEDOWN and MOUSEUP. I think it's probably
OK, but I wanted to throw that out there that we might want to consider revving
the PPB_MouseEvent API for this change in behavior. Anybody think it's worth
revving?

Also, you will need to fill out the CLA before we can accept the patch:
https://developers.google.com/open-source/cla/individual

Thanks!

[yael.aharon, 2013-04-18 22:37:48]

On 2013/04/18 22:32:19, dmichael wrote:
> Thanks for contributing!
> 
> There's a small chance this could break apps that only look for a button to be
> set but don't actually check for MOUSEDOWN and MOUSEUP. I think it's probably
> OK, but I wanted to throw that out there that we might want to consider
revving
> the PPB_MouseEvent API for this change in behavior. Anybody think it's worth
> revving?
> 
> Also, you will need to fill out the CLA before we can accept the patch:
> https://developers.google.com/open-source/cla/individual
> 
> Thanks!
Please let me know if I should rev the API.
I should be under Intel Corporation's CLA. Can you please check that? thanks

[dmichael (off chromium), 2013-04-19 03:46:09]

Sorry about that, I checked the wrong list; you are all set w.r.t. the CLA.

After thinking about it, I think I'm content to consider this a bug and not rev
the API. I think it's unlikely to break existing apps. (If any reviewers
disagree, please speak up).

lgtm, thanks

[commit-bot: I haz the power, 2013-04-19 11:36:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/1

[commit-bot: I haz the power, 2013-04-19 11:36:10]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
6c6622be0b5964eded1fea99aacf94ee27963608..5bfce6c0837a1476e83cd1ddfbd9f952755ec911
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -233,3 +233,4 @@ Sam Larison <qufighter@gmail.com>
 Jun Jiang <jun.a.jiang@intel.com>
 Bobby Powers <bobbypowers@gmail.com>
 Patrick Riordan <patrickriordan177@gmail.com>
+Yael Aharon <yael.aharon@intel.com>

[yael.aharon, 2013-04-19 12:06:49]

On 2013/04/19 11:36:10, I haz the power (commit-bot) wrote:
> Failed to apply patch for AUTHORS:
> While running patch -p1 --forward --force --no-backup-if-mismatch;
>   patching file AUTHORS
>   Hunk #1 FAILED at 233.
>   1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej
> 
> Patch:       AUTHORS
> Index: AUTHORS
> diff --git a/AUTHORS b/AUTHORS
> index
>
6c6622be0b5964eded1fea99aacf94ee27963608..5bfce6c0837a1476e83cd1ddfbd9f952755ec911
> 100644
> --- a/AUTHORS
> +++ b/AUTHORS
> @@ -233,3 +233,4 @@ Sam Larison <mailto:qufighter@gmail.com>
>  Jun Jiang <mailto:jun.a.jiang@intel.com>
>  Bobby Powers <mailto:bobbypowers@gmail.com>
>  Patrick Riordan <mailto:patrickriordan177@gmail.com>
> +Yael Aharon <mailto:yael.aharon@intel.com>

Can someone please commit this for me? I am not a committer and the conflict in
the AUTHORS file is sure to happen again if I rebase :)
thanks!

[commit-bot: I haz the power, 2013-04-19 12:48:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/1

[commit-bot: I haz the power, 2013-04-19 12:48:15]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 233.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
6c6622be0b5964eded1fea99aacf94ee27963608..5bfce6c0837a1476e83cd1ddfbd9f952755ec911
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -233,3 +233,4 @@ Sam Larison <qufighter@gmail.com>
 Jun Jiang <jun.a.jiang@intel.com>
 Bobby Powers <bobbypowers@gmail.com>
 Patrick Riordan <patrickriordan177@gmail.com>
+Yael Aharon <yael.aharon@intel.com>

[commit-bot: I haz the power, 2013-04-19 17:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/8001

[dmichael (off chromium), 2013-04-19 19:30:33]

(If it doesn't go through on the CQ this time, I can get it for you.)


On Fri, Apr 19, 2013 at 1:29 PM, <yael.aharon@intel.com> wrote:

>
https://codereview.chromium.**org/14324006/<https://codereview.chromium.org/1...
>

[commit-bot: I haz the power, 2013-04-19 21:55:15]

Failed to apply patch for AUTHORS:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file AUTHORS
  Hunk #1 FAILED at 237.
  1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

Patch:       AUTHORS
Index: AUTHORS
diff --git a/AUTHORS b/AUTHORS
index
650d4ab66444bee4736a407c817c716c3f19b3c0..a80fd60b987a298dc5c5a5a47a06c32370e7365c
100644
--- a/AUTHORS
+++ b/AUTHORS
@@ -237,3 +237,4 @@ Kenneth Rohde Christiansen
<kenneth.r.christiansen@intel.com>
 Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
 Yandex LLC <*@yandex-team.ru>
 Yoshinori Sano <yoshinori.sano@gmail.com>
+Yael Aharon <yael.aharon@intel.com>

[commit-bot: I haz the power, 2013-04-20 00:48:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/17001

[commit-bot: I haz the power, 2013-04-20 01:02:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/17001

[commit-bot: I haz the power, 2013-04-20 01:14:25]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[yael.aharon, 2013-04-20 01:17:43]

The win_rel failure is clearly unrelated. Is there a way to restart the bot?

[commit-bot: I haz the power, 2013-04-20 11:55:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/17001

[commit-bot: I haz the power, 2013-04-20 12:01:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-22 00:18:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/17001

[commit-bot: I haz the power, 2013-04-22 00:44:07]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-04-22 01:46:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yael.aharon@intel.com/14324006/17001

[commit-bot: I haz the power, 2013-04-22 05:24:30]

Change committed as 195444