android_webview/browser/icon_helper.cc - Issue 14322023: Don't request missing favicon on every page request.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/icon_helper.cc

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync up to r199996 Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/icon_helper.cc

diff --git a/android_webview/browser/icon_helper.cc b/android_webview/browser/icon_helper.cc

index 13091f280d8d0faeb623330c5ba8fb05d06ab888..7f6c4fb1f1e0f4f6b002d45c8574218641bb0110 100644

--- a/android_webview/browser/icon_helper.cc

+++ b/android_webview/browser/icon_helper.cc

@@ -30,7 +30,7 @@ void IconHelper::SetListener(Listener* listener) {

}

void IconHelper::DownloadFaviconCallback(

- int id, const GURL& image_url, int requested_size,

+ int id, int http_status_code, const GURL& image_url, int requested_size,

const std::vector<SkBitmap>& bitmaps) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (bitmaps.size() == 0) {