Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/ui/views/create_application_shortcut_view.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync up to r199996 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 virtual bool Accept() OVERRIDE; 92 virtual bool Accept() OVERRIDE;
93 93
94 private: 94 private:
95 // Fetch the largest unprocessed icon. 95 // Fetch the largest unprocessed icon.
96 // The first largest icon downloaded and decoded successfully will be used. 96 // The first largest icon downloaded and decoded successfully will be used.
97 void FetchIcon(); 97 void FetchIcon();
98 98
99 // Favicon download callback. 99 // Favicon download callback.
100 void DidDownloadFavicon( 100 void DidDownloadFavicon(
101 int id, 101 int id,
102 int http_status_code,
102 const GURL& image_url, 103 const GURL& image_url,
103 int requested_size, 104 int requested_size,
104 const std::vector<SkBitmap>& bitmaps); 105 const std::vector<SkBitmap>& bitmaps);
105 106
106 // The tab whose URL is being turned into an app. 107 // The tab whose URL is being turned into an app.
107 content::WebContents* web_contents_; 108 content::WebContents* web_contents_;
108 109
109 // Pending app icon download tracked by us. 110 // Pending app icon download tracked by us.
110 int pending_download_id_; 111 int pending_download_id_;
111 112
(...skipping 16 matching lines...) Expand all
128 const ShellIntegration::ShortcutInfo& shortcut_info); 129 const ShellIntegration::ShortcutInfo& shortcut_info);
129 130
130 const extensions::Extension* app_; 131 const extensions::Extension* app_;
131 132
132 base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_; 133 base::WeakPtrFactory<CreateChromeApplicationShortcutView> weak_ptr_factory_;
133 134
134 DISALLOW_COPY_AND_ASSIGN(CreateChromeApplicationShortcutView); 135 DISALLOW_COPY_AND_ASSIGN(CreateChromeApplicationShortcutView);
135 }; 136 };
136 137
137 #endif // CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_ 138 #endif // CHROME_BROWSER_UI_VIEWS_CREATE_APPLICATION_SHORTCUT_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/metro_pin_tab_helper_win.cc ('k') | chrome/browser/ui/views/create_application_shortcut_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698