Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: chrome/browser/ui/metro_pin_tab_helper_win.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync up to r199996 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_ 5 #ifndef CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_
6 #define CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_ 6 #define CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "content/public/browser/web_contents_observer.h" 10 #include "content/public/browser/web_contents_observer.h"
(...skipping 25 matching lines...) Expand all
36 // The FaviconDownloader class handles downloading the favicons when a page 36 // The FaviconDownloader class handles downloading the favicons when a page
37 // is being pinned. After it has downloaded any available favicons it will 37 // is being pinned. After it has downloaded any available favicons it will
38 // continue on with the page pinning action. 38 // continue on with the page pinning action.
39 class FaviconChooser; 39 class FaviconChooser;
40 40
41 explicit MetroPinTabHelper(content::WebContents* web_contents); 41 explicit MetroPinTabHelper(content::WebContents* web_contents);
42 friend class content::WebContentsUserData<MetroPinTabHelper>; 42 friend class content::WebContentsUserData<MetroPinTabHelper>;
43 43
44 // Favicon download callback. 44 // Favicon download callback.
45 void DidDownloadFavicon(int id, 45 void DidDownloadFavicon(int id,
46 int http_status_code,
46 const GURL& image_url, 47 const GURL& image_url,
47 int requested_size, 48 int requested_size,
48 const std::vector<SkBitmap>& bitmaps); 49 const std::vector<SkBitmap>& bitmaps);
49 50
50 void UnPinPageFromStartScreen(); 51 void UnPinPageFromStartScreen();
51 52
52 // Called by the |favicon_chooser_| when it has finished. 53 // Called by the |favicon_chooser_| when it has finished.
53 void FaviconDownloaderFinished(); 54 void FaviconDownloaderFinished();
54 55
55 // Candidate Favicon URLs for the current page. 56 // Candidate Favicon URLs for the current page.
56 std::vector<content::FaviconURL> favicon_url_candidates_; 57 std::vector<content::FaviconURL> favicon_url_candidates_;
57 58
58 // The currently active FaviconChooser, if there is one. 59 // The currently active FaviconChooser, if there is one.
59 scoped_ptr<FaviconChooser> favicon_chooser_; 60 scoped_ptr<FaviconChooser> favicon_chooser_;
60 61
61 62
62 DISALLOW_COPY_AND_ASSIGN(MetroPinTabHelper); 63 DISALLOW_COPY_AND_ASSIGN(MetroPinTabHelper);
63 }; 64 };
64 65
65 #endif // CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_ 66 #endif // CHROME_BROWSER_UI_METRO_PIN_TAB_HELPER_WIN_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.cc ('k') | chrome/browser/ui/metro_pin_tab_helper_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698