Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: chrome/browser/ui/extensions/shell_window.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync up to r199996 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_ 5 #ifndef CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_
6 #define CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_ 6 #define CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/memory/weak_ptr.h" 9 #include "base/memory/weak_ptr.h"
10 #include "chrome/browser/extensions/extension_keybinding_registry.h" 10 #include "chrome/browser/extensions/extension_keybinding_registry.h"
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 GetActiveTabPermissionGranter() OVERRIDE; 262 GetActiveTabPermissionGranter() OVERRIDE;
263 263
264 // WebContentsModalDialogManagerDelegate implementation. 264 // WebContentsModalDialogManagerDelegate implementation.
265 virtual void SetWebContentsBlocked(content::WebContents* web_contents, 265 virtual void SetWebContentsBlocked(content::WebContents* web_contents,
266 bool blocked) OVERRIDE; 266 bool blocked) OVERRIDE;
267 267
268 virtual WebContentsModalDialogHost* GetWebContentsModalDialogHost() OVERRIDE; 268 virtual WebContentsModalDialogHost* GetWebContentsModalDialogHost() OVERRIDE;
269 269
270 // Callback from web_contents()->DownloadFavicon. 270 // Callback from web_contents()->DownloadFavicon.
271 void DidDownloadFavicon(int id, 271 void DidDownloadFavicon(int id,
272 int http_status_code,
272 const GURL& image_url, 273 const GURL& image_url,
273 int requested_size, 274 int requested_size,
274 const std::vector<SkBitmap>& bitmaps); 275 const std::vector<SkBitmap>& bitmaps);
275 276
276 Profile* profile_; // weak pointer - owned by ProfileManager. 277 Profile* profile_; // weak pointer - owned by ProfileManager.
277 // weak pointer - owned by ExtensionService. 278 // weak pointer - owned by ExtensionService.
278 const extensions::Extension* extension_; 279 const extensions::Extension* extension_;
279 const std::string extension_id_; 280 const std::string extension_id_;
280 281
281 // Identifier that is used when saving and restoring geometry for this 282 // Identifier that is used when saving and restoring geometry for this
(...skipping 18 matching lines...) Expand all
300 301
301 // Fullscreen entered by app.window api. 302 // Fullscreen entered by app.window api.
302 bool fullscreen_for_window_api_; 303 bool fullscreen_for_window_api_;
303 // Fullscreen entered by HTML requestFullscreen. 304 // Fullscreen entered by HTML requestFullscreen.
304 bool fullscreen_for_tab_; 305 bool fullscreen_for_tab_;
305 306
306 DISALLOW_COPY_AND_ASSIGN(ShellWindow); 307 DISALLOW_COPY_AND_ASSIGN(ShellWindow);
307 }; 308 };
308 309
309 #endif // CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_ 310 #endif // CHROME_BROWSER_UI_EXTENSIONS_SHELL_WINDOW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/launcher/launcher_favicon_loader.cc ('k') | chrome/browser/ui/extensions/shell_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698