Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: android_webview/browser/icon_helper.h

Issue 14322023: Don't request missing favicon on every page request. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sync up to r199996 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | android_webview/browser/icon_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 5 #ifndef ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
6 #define ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 6 #define ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
7 7
8 #include <string> 8 #include <string>
9 #include "content/public/browser/web_contents_observer.h" 9 #include "content/public/browser/web_contents_observer.h"
10 10
(...skipping 19 matching lines...) Expand all
30 30
31 explicit IconHelper(content::WebContents* web_contents); 31 explicit IconHelper(content::WebContents* web_contents);
32 virtual ~IconHelper(); 32 virtual ~IconHelper();
33 33
34 void SetListener(Listener* listener); 34 void SetListener(Listener* listener);
35 35
36 // From WebContentsObserver 36 // From WebContentsObserver
37 virtual void DidUpdateFaviconURL(int32 page_id, 37 virtual void DidUpdateFaviconURL(int32 page_id,
38 const std::vector<content::FaviconURL>& candidates) OVERRIDE; 38 const std::vector<content::FaviconURL>& candidates) OVERRIDE;
39 39
40 void DownloadFaviconCallback(int id, const GURL& image_url, 40 void DownloadFaviconCallback(int id, int http_status_code,
41 int requested_size, const std::vector<SkBitmap>& bitmaps); 41 const GURL& image_url, int requested_size,
42 const std::vector<SkBitmap>& bitmaps);
42 43
43 private: 44 private:
44 Listener* listener_; 45 Listener* listener_;
45 46
46 DISALLOW_COPY_AND_ASSIGN(IconHelper); 47 DISALLOW_COPY_AND_ASSIGN(IconHelper);
47 }; 48 };
48 49
49 } // namespace android_webview 50 } // namespace android_webview
50 51
51 #endif // ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_ 52 #endif // ANDROID_WEBVIEW_BROWSER_ICON_HELPER_H_
OLDNEW
« no previous file with comments | « no previous file | android_webview/browser/icon_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698