Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 14322014: Support ninja flavor (Closed)

Created:
7 years, 8 months ago by Shezan Baig (Bloomberg)
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Isaac (away)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Support ninja flavor This is in order to support the "msvs-ninja" generator, which is being added in https://codereview.chromium.org/13867004/. R=ilevy@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197456

Patch Set 1 #

Patch Set 2 : add Bloomberg to AUTHORS #

Total comments: 1

Patch Set 3 : fix AUTHORS to add myself only #

Patch Set 4 : rebased AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M AUTHORS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/landmines.py View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Isaac (away)
Thanks for the submission. iannucci@ -- could you take a look at this code? I'm ...
7 years, 8 months ago (2013-04-22 22:25:08 UTC) #1
Mark Larson
https://codereview.chromium.org/14322014/diff/2001/AUTHORS File AUTHORS (right): https://codereview.chromium.org/14322014/diff/2001/AUTHORS#newcode236 AUTHORS:236: Bloomberg Finance L.P. <*@bloomberg.net> Bloomberg Finance has a specific ...
7 years, 8 months ago (2013-04-22 22:46:18 UTC) #2
Shezan Baig (Bloomberg)
Thanks, I've updated the AUTHORS file
7 years, 8 months ago (2013-04-23 12:58:35 UTC) #3
iannucci
This lgtm. Thanks for working on this! I was just thinking that this functionality would ...
7 years, 8 months ago (2013-04-23 16:30:29 UTC) #4
Shezan Baig (Bloomberg)
mal@, after consulting with another developer at Bloomberg, it seems that "Bloomberg Finance L.P." is ...
7 years, 8 months ago (2013-04-24 19:57:24 UTC) #5
Mark Larson
On 2013/04/24 19:57:24, Shezan Baig (Bloomberg) wrote: > mal@, after consulting with another developer at ...
7 years, 8 months ago (2013-04-25 01:08:23 UTC) #6
Shezan Baig (Bloomberg)
Hi, is this OK to commit now?
7 years, 7 months ago (2013-04-30 16:21:11 UTC) #7
Mark Larson
On 2013/04/30 16:21:11, Shezan Baig (Bloomberg) wrote: > Hi, is this OK to commit now? ...
7 years, 7 months ago (2013-04-30 16:28:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbaig1@bloomberg.net/14322014/8001
7 years, 7 months ago (2013-04-30 16:30:20 UTC) #9
commit-bot: I haz the power
Failed to apply patch for AUTHORS: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-04-30 16:30:22 UTC) #10
Shezan Baig (Bloomberg)
Thanks, I'll rebase the AUTHORS file and upload a new patch
7 years, 7 months ago (2013-04-30 16:31:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbaig1@bloomberg.net/14322014/18001
7 years, 7 months ago (2013-04-30 16:50:30 UTC) #12
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-04-30 16:54:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sbaig1@bloomberg.net/14322014/18001
7 years, 7 months ago (2013-04-30 18:34:32 UTC) #14
commit-bot: I haz the power
7 years, 7 months ago (2013-04-30 20:39:18 UTC) #15
Message was sent while issue was closed.
Change committed as 197456

Powered by Google App Engine
This is Rietveld 408576698