Issue 14322004: [Android] Fix forwarder for the component build

Issue 14322004: [Android] Fix forwarder for the component build (Closed)

Created:
7 years, 8 months ago by Yaron

Modified:
7 years, 8 months ago

Reviewers:
cjhopman

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, erikwright+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Android] Fix forwarder for the component build Repurposes the gyp scripts for processing native libraries for an apk and use them for a native library (i.e. forwarder). Additionally, adjusts the forwarder python script to set LD_LIBRARY_PATH when invoking the forwarder. BUG=158821 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194833

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : fix non-managed #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : change distribution folder to fowarder_dist to avoid colliding with forwarder (1) #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+247 lines, -148 lines)			Patch
D	build/android/gyp/strip_library_for_apk.py	View		1 chunk	+0 lines, -59 lines	0 comments	Download
A +	build/android/gyp/strip_library_for_device.py	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	build/android/gyp/write_ordered_libraries.py	View	1	4 chunks	+19 lines, -13 lines	0 comments	Download
A	build/android/native_app_dependencies.gypi	View	1 2	1 chunk	+64 lines, -0 lines	0 comments	Download
A	build/android/push_libraries.gypi	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download
M	build/android/pylib/forwarder.py	View	1 2 3 4	4 chunks	+11 lines, -6 lines	0 comments	Download
A	build/android/strip_native_libraries.gypi	View	1	1 chunk	+45 lines, -0 lines	0 comments	Download
A	build/android/write_ordered_libraries.gypi	View	1	1 chunk	+42 lines, -0 lines	0 comments	Download
M	build/java_apk.gypi	View	1	7 chunks	+12 lines, -71 lines	0 comments	Download
M	tools/android/forwarder2/forwarder.gyp	View	1 2 3 4	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Yaron

Ok, now should work for non-managed case. It no longer copies the dependent libraries due ...

7 years, 8 months ago (2013-04-17 21:48:49 UTC) #2

cjhopman

lgtm https://codereview.chromium.org/14322004/diff/13001/tools/android/forwarder2/forwarder.gyp File tools/android/forwarder2/forwarder.gyp (right): https://codereview.chromium.org/14322004/diff/13001/tools/android/forwarder2/forwarder.gyp#newcode15 tools/android/forwarder2/forwarder.gyp:15: # the device. Nit: Update this comment now ...

7 years, 8 months ago (2013-04-18 00:43:16 UTC) #3

Yaron

On 2013/04/18 00:43:16, cjhopman wrote: > lgtm > > https://codereview.chromium.org/14322004/diff/13001/tools/android/forwarder2/forwarder.gyp > File tools/android/forwarder2/forwarder.gyp (right): > ...

7 years, 8 months ago (2013-04-18 01:09:16 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/14322004/20001

7 years, 8 months ago (2013-04-18 01:10:34 UTC) #5

Message was sent while issue was closed.

Change committed as 194833

Expand Messages | Collapse Messages