Issue 14320028: Restore skipping of default categories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14320028: Restore skipping of default categories. (Closed)

Created:
7 years, 8 months ago by dsinclair

Modified:
7 years, 8 months ago

Reviewers:
nduca, jar (doing other things)

CC:
chromium-reviews, erikwright+watch_chromium.org, rterrazas

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Restore skipping of default categories. Looks like the code to skip the default categories, and the unit test, were removed by accident in a merge. Restoring so the category selection dialog works correctly. BUG=195661 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195295

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	base/debug/trace_event_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	base/debug/trace_event_unittest.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

dsinclair

jar, can you PTAL for base OWNERS? This is just restoring some code that should ...

7 years, 8 months ago (2013-04-19 17:52:10 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14320028/1

7 years, 8 months ago (2013-04-19 18:51:23 UTC) #4

commit-bot: I haz the power

Step "update" is always a major failure. Look at the try server FAQ for more ...

7 years, 8 months ago (2013-04-19 18:52:22 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14320028/1

7 years, 8 months ago (2013-04-19 18:53:55 UTC) #6

Message was sent while issue was closed.

Change committed as 195295

Expand Messages | Collapse Messages