Warn developers about deprecated features only once per page-load.

Warn developers about deprecated features only once per page-load.

As a first step towards removing deprecated features from Blink, we should warn
developers that they're using APIs that won't be sticking around forever. This
patch introduces PageConsole::reportDeprecation in order to streamline this
process, and make it trivial to find deprecated features in the codebase.

BUG=233522
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=148726

[pfeldman, 2013-04-19 12:53:18]

Mike says there is a not lgtm. Is there?

[pfeldman, 2013-04-19 13:04:21]

lgtm with nits

https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
File Source/core/page/DeprecationAgent.cpp (right):

https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
Source/core/page/DeprecationAgent.cpp:47: //
COMPILE_ASSERT(WTF_ARRAY_LENGTH(deprecationMessages) ==
static_cast<int>(WebCore::DeprecationAgent::NumberOfFeatures),
DeprecationMessages_matches_Feature_enum);
It should work, right?

https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
Source/core/page/DeprecationAgent.cpp:81: if (m_countBits->quickGet(feature))
Is this covered with the tests? I.e. are you generating a number of them and
check that notification only comes once?

https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
File Source/core/page/DeprecationAgent.h (right):

https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
Source/core/page/DeprecationAgent.h:50: class DeprecationAgent {
It is so small that it feels like deprecation could be one of the PageConsole's
responsibilities.

[Use mkwst_at_chromium.org plz., 2013-04-19 13:28:18]

On 2013/04/19 13:04:21, pfeldman wrote:
https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
> File Source/core/page/DeprecationAgent.h (right):
> 
>
https://codereview.chromium.org/14320022/diff/1/Source/core/page/DeprecationA...
> Source/core/page/DeprecationAgent.h:50: class DeprecationAgent {
> It is so small that it feels like deprecation could be one of the
PageConsole's
> responsibilities.

Hrm. This makes a lot of sense. I'll spin up a new patch to try that out.

[Mike West, 2013-04-19 14:03:34]

Since the implementation has more or less completely changed, would you mind
taking another look, Pavel?

Thanks!

-mike

[pfeldman, 2013-04-19 14:19:50]

lgtm

https://codereview.chromium.org/14320022/diff/5002/Source/core/page/PageConso...
File Source/core/page/PageConsole.cpp (right):

https://codereview.chromium.org/14320022/diff/5002/Source/core/page/PageConso...
Source/core/page/PageConsole.cpp:143: m_deprecationNotifications = adoptPtr(new
BitVector(NumberOfFeatures));
BitVector is not going to take much space.

[commit-bot: I haz the power, 2013-04-19 14:55:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/14320022/15

[commit-bot: I haz the power, 2013-04-19 14:55:29]

Change committed as 148726