Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14320015: chromeos: Fix wrong ZipSelectionFunction src_dir check (Closed)

Created:
7 years, 8 months ago by hashimoto
Modified:
7 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

chromeos: Fix wrong ZipSelectionFunction src_dir check GetLocalPathFromURL returns the logical path, not the cache path of the entry. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195206

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hashimoto
7 years, 8 months ago (2013-04-19 05:47:04 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-19 05:48:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14320015/1
7 years, 8 months ago (2013-04-19 05:49:11 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 06:19:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14320015/1
7 years, 8 months ago (2013-04-19 06:25:38 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-19 06:47:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/14320015/1
7 years, 8 months ago (2013-04-19 08:40:51 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 15:17:47 UTC) #8
Message was sent while issue was closed. 
Change committed as 195206

Powered by Google App Engine
This is Rietveld 408576698