remoting: Use base::MessageLoop.

remoting: Use base::MessageLoop.

BUG=236029
R=alexeypa@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197247

[alexeypa (please no reviews), 2013-04-29 17:17:41]

lgtm once my comments are addressed.

https://codereview.chromium.org/14314026/diff/1/remoting/host/config_file_wat...
File remoting/host/config_file_watcher_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/config_file_wat...
remoting/host/config_file_watcher_unittest.cc:65: :
message_loop_(base::MessageLoop::TYPE_UI) {}
nit: Please move the closing bracket to the next line. This style is used
elsewhere in remoting/src when the initializers list is present.

https://codereview.chromium.org/14314026/diff/1/remoting/host/daemon_process_...
File remoting/host/daemon_process_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/daemon_process_...
remoting/host/daemon_process_unittest.cc:155: :
message_loop_(base::MessageLoop::TYPE_IO), terminal_id_(0) {}
nit: Please move the closing bracket to the next line and have one member per
line.

https://codereview.chromium.org/14314026/diff/1/remoting/host/ipc_desktop_env...
File remoting/host/ipc_desktop_environment_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/ipc_desktop_env...
remoting/host/ipc_desktop_environment_unittest.cc:214:
client_session_control_factory_(&client_session_control_) {}
nit: Please move the closing bracket to the next line.

https://codereview.chromium.org/14314026/diff/1/remoting/host/linux/audio_pip...
File remoting/host/linux/audio_pipe_reader.h (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/linux/audio_pip...
remoting/host/linux/audio_pipe_reader.h:26: class AudioPipeReader :
nit: the colon should go to the next line.

https://codereview.chromium.org/14314026/diff/1/remoting/host/win/rdp_client_...
File remoting/host/win/rdp_client_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/win/rdp_client_...
remoting/host/win/rdp_client_unittest.cc:108: RdpClientTest::RdpClientTest() :
message_loop_(base::MessageLoop::TYPE_UI) {}
nit: Please move |message_loop_| initialization to the next line and the closing
bracket - to its own line.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/connection_...
File remoting/protocol/connection_tester.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/connection_...
remoting/protocol/connection_tester.cc:28: read_errors_(0) {}
nit: the closing bracket should got to a separate line.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
File remoting/protocol/fake_session.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:30: weak_factory_(this) {}
nit: Please move the closing bracket to the next line.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:214:
message_loop_(base::MessageLoop::current()) {}
nit: Please move the closing bracket to the next line.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:280: weak_factory_(this) {}
nit: Please move the closing bracket to the next line.

[xhwang, 2013-04-30 00:02:35]

All comments resolved.

Sorry about the mess. As you can imagine, it's intimidating to update all of
these by hand. So I am using clang-format-diff to help reformatting (if case
over 80char limit or wrong indentation after add base::). Unfortunately
clang-format-diff doesn't always agree with the existing code style.

https://codereview.chromium.org/14314026/diff/1/remoting/host/config_file_wat...
File remoting/host/config_file_watcher_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/config_file_wat...
remoting/host/config_file_watcher_unittest.cc:65: :
message_loop_(base::MessageLoop::TYPE_UI) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line. This style is used
> elsewhere in remoting/src when the initializers list is present.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/host/daemon_process_...
File remoting/host/daemon_process_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/daemon_process_...
remoting/host/daemon_process_unittest.cc:155: :
message_loop_(base::MessageLoop::TYPE_IO), terminal_id_(0) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line and have one member per
> line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/host/ipc_desktop_env...
File remoting/host/ipc_desktop_environment_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/ipc_desktop_env...
remoting/host/ipc_desktop_environment_unittest.cc:214:
client_session_control_factory_(&client_session_control_) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/host/linux/audio_pip...
File remoting/host/linux/audio_pipe_reader.h (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/linux/audio_pip...
remoting/host/linux/audio_pipe_reader.h:26: class AudioPipeReader :
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: the colon should go to the next line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/host/win/rdp_client_...
File remoting/host/win/rdp_client_unittest.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/host/win/rdp_client_...
remoting/host/win/rdp_client_unittest.cc:108: RdpClientTest::RdpClientTest() :
message_loop_(base::MessageLoop::TYPE_UI) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move |message_loop_| initialization to the next line and the
closing
> bracket - to its own line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/connection_...
File remoting/protocol/connection_tester.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/connection_...
remoting/protocol/connection_tester.cc:28: read_errors_(0) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: the closing bracket should got to a separate line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
File remoting/protocol/fake_session.cc (right):

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:30: weak_factory_(this) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:214:
message_loop_(base::MessageLoop::current()) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line.

Done.

https://codereview.chromium.org/14314026/diff/1/remoting/protocol/fake_sessio...
remoting/protocol/fake_session.cc:280: weak_factory_(this) {}
On 2013/04/29 17:17:41, alexeypa wrote:
> nit: Please move the closing bracket to the next line.

Done.

[commit-bot: I haz the power, 2013-04-30 00:03:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/14314026/24001

[commit-bot: I haz the power, 2013-04-30 00:04:08]

Failed to apply patch for remoting/host/clipboard_linux.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: remoting/host/clipboard_linux.cc
  |diff --git a/remoting/host/clipboard_linux.cc
b/remoting/host/clipboard_linux.cc
  |index
e436859e0942de0349064709e5d4514a23a354e9..9fd3a27b9c5d53a31f798ba54842d45eb7199041
100644
  |--- a/remoting/host/clipboard_linux.cc
  |+++ b/remoting/host/clipboard_linux.cc
  --------------------------
  No file to patch.  Skipping patch.
  3 out of 3 hunks ignored

Patch:       remoting/host/clipboard_linux.cc
Index: remoting/host/clipboard_linux.cc
diff --git a/remoting/host/clipboard_linux.cc b/remoting/host/clipboard_linux.cc
index
e436859e0942de0349064709e5d4514a23a354e9..9fd3a27b9c5d53a31f798ba54842d45eb7199041
100644
--- a/remoting/host/clipboard_linux.cc
+++ b/remoting/host/clipboard_linux.cc
@@ -17,7 +17,7 @@ namespace remoting {
 
 // This code is expected to be called on the desktop thread only.
 class ClipboardLinux : public Clipboard,
-                       public MessageLoopForIO::Watcher {
+                       public base::MessageLoopForIO::Watcher {
  public:
   ClipboardLinux();
   virtual ~ClipboardLinux();
@@ -48,7 +48,7 @@ class ClipboardLinux : public Clipboard,
   Display* display_;
 
   // Watcher used to handle X11 events from |display_|.
-  MessageLoopForIO::FileDescriptorWatcher x_connection_watcher_;
+  base::MessageLoopForIO::FileDescriptorWatcher x_connection_watcher_;
 
   DISALLOW_COPY_AND_ASSIGN(ClipboardLinux);
 };
@@ -75,9 +75,12 @@ void ClipboardLinux::Start(
                            base::Bind(&ClipboardLinux::OnClipboardChanged,
                                       base::Unretained(this)));
 
-  MessageLoopForIO::current()->WatchFileDescriptor(
-      ConnectionNumber(display_), true, MessageLoopForIO::WATCH_READ,
-      &x_connection_watcher_, this);
+  base::MessageLoopForIO::current()->WatchFileDescriptor(
+      ConnectionNumber(display_),
+      true,
+      base::MessageLoopForIO::WATCH_READ,
+      &x_connection_watcher_,
+      this);
   PumpXEvents();
 }

[commit-bot: I haz the power, 2013-04-30 00:13:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xhwang@chromium.org/14314026/31001

[commit-bot: I haz the power, 2013-04-30 03:18:48]

Change committed as 197247