Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 14314022: android_webview: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang
Modified:
7 years, 8 months ago
Reviewers:
joth
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Visibility:
Public.

Description

android_webview: Use base::MessageLoop. BUG=236029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196944

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M android_webview/browser/aw_browser_main_parts.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_web_contents_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/renderer/aw_content_renderer_client.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
xhwang
PTAL! Format is corrected by clang-format-diff.py. If you feel any format change is bad please ...
7 years, 8 months ago (2013-04-27 00:38:23 UTC) #1
joth
lgtm https://codereview.chromium.org/14314022/diff/1/android_webview/browser/aw_browser_main_parts.cc File android_webview/browser/aw_browser_main_parts.cc (right): https://codereview.chromium.org/14314022/diff/1/android_webview/browser/aw_browser_main_parts.cc#newcode44 android_webview/browser/aw_browser_main_parts.cc:44: // Android specific base::MessageLoop. Also see MainMessageLoopRun. nit: ...
7 years, 8 months ago (2013-04-27 00:59:19 UTC) #2
xhwang
https://codereview.chromium.org/14314022/diff/1/android_webview/browser/aw_browser_main_parts.cc File android_webview/browser/aw_browser_main_parts.cc (right): https://codereview.chromium.org/14314022/diff/1/android_webview/browser/aw_browser_main_parts.cc#newcode44 android_webview/browser/aw_browser_main_parts.cc:44: // Android specific base::MessageLoop. Also see MainMessageLoopRun. On 2013/04/27 ...
7 years, 8 months ago (2013-04-27 01:19:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14314022/1008
7 years, 8 months ago (2013-04-27 01:19:11 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-27 04:48:45 UTC) #5
Message was sent while issue was closed.
Change committed as 196944

Powered by Google App Engine
This is Rietveld 408576698