Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: ppapi/proxy/flash_resource.cc

Issue 14311004: Add interface to set the sub resource crash key from Flash (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/private/ppb_flash.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/flash_resource.cc
===================================================================
--- ppapi/proxy/flash_resource.cc (revision 194456)
+++ ppapi/proxy/flash_resource.cc (working copy)
@@ -7,6 +7,7 @@
#include <cmath>
#include "base/containers/mru_cache.h"
+#include "base/debug/crash_logging.h"
#include "base/lazy_instance.h"
#include "base/time.h"
#include "ppapi/c/pp_errors.h"
@@ -83,14 +84,18 @@
PP_Bool FlashResource::SetCrashData(PP_Instance instance,
PP_FlashCrashKey key,
PP_Var value) {
+ StringVar* url_string_var(StringVar::FromPPVar(value));
+ if (!url_string_var)
+ return PP_FALSE;
switch (key) {
case PP_FLASHCRASHKEY_URL: {
- StringVar* url_string_var(StringVar::FromPPVar(value));
- if (!url_string_var)
- return PP_FALSE;
PluginGlobals::Get()->SetActiveURL(url_string_var->value());
return PP_TRUE;
}
+ case PP_FLASHCRASHKEY_RESOURCE_URL: {
+ base::debug::SetCrashKeyValue("subresource_url", url_string_var->value());
+ return PP_TRUE;
+ }
}
return PP_FALSE;
}
« no previous file with comments | « ppapi/c/private/ppb_flash.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698