chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc - Issue 14307023: chrome: Use base::MessageLoop. (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc

Issue 14307023: chrome: Use base::MessageLoop. (Part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk.cc ('k') | chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc

index 9718e28a523e76b9b6538294f88284b4f4655b67..fe0922d8d3428c5abb9bd187d6f8ea04d8e4f871 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_bar_gtk_interactive_uitest.cc

@@ -45,7 +45,7 @@ IN_PROC_BROWSER_TEST_F(BookmarkBarGtkInteractiveUITest, FindBarTest) {

browser()->tab_strip_model()->ActivateTabAt(1, false);

// Wait for the findbar to show.

- MessageLoop::current()->RunUntilIdle();

+ base::MessageLoop::current()->RunUntilIdle();

// Set focus somewhere else, so that we can test clicking on the findbar

// works.

@@ -71,7 +71,7 @@ IN_PROC_BROWSER_TEST_F(

chrome::NewTab(browser());

// Wait for the floating bar to appear.

- MessageLoop::current()->RunUntilIdle();

+ base::MessageLoop::current()->RunUntilIdle();

// This is kind of a hack. Calling this just once doesn't seem to send a click

// event, but doing it twice works.