Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: chrome/browser/ui/cocoa/about_ipc_controller_unittest.mm

Issue 14307023: chrome: Use base::MessageLoop. (Part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 6
7 #import "base/memory/scoped_nsobject.h" 7 #import "base/memory/scoped_nsobject.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #import "chrome/browser/ui/cocoa/about_ipc_controller.h" 9 #import "chrome/browser/ui/cocoa/about_ipc_controller.h"
10 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h" 10 #include "chrome/browser/ui/cocoa/cocoa_test_helper.h"
11 #include "content/public/test/test_browser_thread.h" 11 #include "content/public/test/test_browser_thread.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 #include "testing/platform_test.h" 13 #include "testing/platform_test.h"
14 14
15 #if defined(IPC_MESSAGE_LOG_ENABLED) 15 #if defined(IPC_MESSAGE_LOG_ENABLED)
16 16
17 namespace { 17 namespace {
18 18
19 class AboutIPCControllerTest : public CocoaTest { 19 class AboutIPCControllerTest : public CocoaTest {
20 public: 20 public:
21 virtual void SetUp() { 21 virtual void SetUp() {
22 CocoaTest::SetUp(); 22 CocoaTest::SetUp();
23 ui_message_loop_.reset(new MessageLoopForUI()); 23 ui_message_loop_.reset(new base::MessageLoopForUI());
24 ui_thread_.reset(new content::TestBrowserThread(content::BrowserThread::UI, 24 ui_thread_.reset(new content::TestBrowserThread(
25 MessageLoop::current())); 25 content::BrowserThread::UI, base::MessageLoop::current()));
26 } 26 }
27 27
28 virtual void TearDown() { 28 virtual void TearDown() {
29 CocoaTest::TearDown(); 29 CocoaTest::TearDown();
30 ui_thread_.reset(NULL); 30 ui_thread_.reset(NULL);
31 } 31 }
32 32
33 private: 33 private:
34 scoped_ptr<MessageLoopForUI> ui_message_loop_; 34 scoped_ptr<base::MessageLoopForUI> ui_message_loop_;
35 scoped_ptr<content::TestBrowserThread> ui_thread_; 35 scoped_ptr<content::TestBrowserThread> ui_thread_;
36 }; 36 };
37 37
38 TEST_F(AboutIPCControllerTest, TestFilter) { 38 TEST_F(AboutIPCControllerTest, TestFilter) {
39 AboutIPCController* controller = [[AboutIPCController alloc] init]; 39 AboutIPCController* controller = [[AboutIPCController alloc] init];
40 EXPECT_TRUE([controller window]); // force nib load. 40 EXPECT_TRUE([controller window]); // force nib load.
41 IPC::LogData data; 41 IPC::LogData data;
42 42
43 // Make sure generic names do NOT get filtered. 43 // Make sure generic names do NOT get filtered.
44 std::string names[] = { "PluginProcessingIsMyLife", 44 std::string names[] = { "PluginProcessingIsMyLife",
(...skipping 13 matching lines...) Expand all
58 [controller setDisplayViewMessages:NO]; 58 [controller setDisplayViewMessages:NO];
59 EXPECT_TRUE([controller filterOut:cdata.get()]); 59 EXPECT_TRUE([controller filterOut:cdata.get()]);
60 [controller setDisplayViewMessages:YES]; 60 [controller setDisplayViewMessages:YES];
61 EXPECT_FALSE([controller filterOut:cdata.get()]); 61 EXPECT_FALSE([controller filterOut:cdata.get()]);
62 [controller close]; 62 [controller close];
63 } 63 }
64 64
65 } // namespace 65 } // namespace
66 66
67 #endif // IPC_MESSAGE_LOG_ENABLED 67 #endif // IPC_MESSAGE_LOG_ENABLED
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698