Issue 14307021: jingle: Use base::MessageLoop.

Issue 14307021: jingle: Use base::MessageLoop. (Closed)

Created:
7 years, 8 months ago by xhwang

Modified:
7 years, 8 months ago

Reviewers:
awong

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

jingle: Use base::MessageLoop. BUG=236029 R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196960

Patch Set 1 #

Total comments: 3

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -58 lines)			Patch
M	jingle/glue/channel_socket_adapter.cc	View	7 chunks	+9 lines, -9 lines	0 comments	Download
M	jingle/glue/channel_socket_adapter_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/chrome_async_socket.cc	View	4 chunks	+4 lines, -4 lines	0 comments	Download
M	jingle/glue/chrome_async_socket_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/fake_network_manager.cc	View	1 chunk	+4 lines, -3 lines	0 comments	Download
M	jingle/glue/fake_socket_factory.cc	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	jingle/glue/fake_ssl_client_socket_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/proxy_resolving_client_socket.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	jingle/glue/proxy_resolving_client_socket_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/pseudotcp_adapter_unittest.cc	View	7 chunks	+9 lines, -10 lines	0 comments	Download
M	jingle/glue/task_pump.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/glue/task_pump_unittest.cc	View	3 chunks	+3 lines, -3 lines	2 comments	Download
M	jingle/glue/thread_wrapper.h	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	jingle/glue/thread_wrapper.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	jingle/glue/thread_wrapper_unittest.cc	View	3 chunks	+5 lines, -3 lines	1 comment	Download
M	jingle/notifier/base/weak_xmpp_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/xmpp_connection.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/base/xmpp_connection_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/communicator/single_login_attempt_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/listener/non_blocking_push_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/listener/push_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	jingle/notifier/listener/xmpp_push_client_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

xhwang

PTAL! Format is corrected by clang-format-diff.py. If you feel any format change is bad please ...

7 years, 8 months ago (2013-04-27 00:32:22 UTC) #1

awong

https://codereview.chromium.org/14307021/diff/1/jingle/glue/task_pump_unittest.cc File jingle/glue/task_pump_unittest.cc (right): https://codereview.chromium.org/14307021/diff/1/jingle/glue/task_pump_unittest.cc#newcode19 jingle/glue/task_pump_unittest.cc:19: base::MessageLoop message_loop_; Should this use RunLoop instead? https://codereview.chromium.org/14307021/diff/1/jingle/glue/thread_wrapper_unittest.cc File ...

7 years, 8 months ago (2013-04-27 00:35:04 UTC) #2

xhwang

7 years, 8 months ago (2013-04-27 05:03:03 UTC) #3

awong

LGTM On Fri, Apr 26, 2013 at 10:03 PM, <xhwang@chromium.org> wrote: > > https://codereview.chromium.**org/14307021/diff/1/jingle/** > ...

7 years, 8 months ago (2013-04-27 05:40:34 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xhwang@chromium.org/14307021/1

7 years, 8 months ago (2013-04-27 05:50:05 UTC) #5

Message was sent while issue was closed.

Change committed as 196960

Expand Messages | Collapse Messages