Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: gcl.py

Issue 14305019: Fix gcl.py error introduced in r196786. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """\ 6 """\
7 Wrapper script around Rietveld's upload.py that simplifies working with groups 7 Wrapper script around Rietveld's upload.py that simplifies working with groups
8 of files. 8 of files.
9 """ 9 """
10 10
(...skipping 371 matching lines...) Expand 10 before | Expand all | Expand 10 after
382 return self.SendToRietveld('/%d/description' % self.issue) 382 return self.SendToRietveld('/%d/description' % self.issue)
383 383
384 def UpdateDescriptionFromIssue(self): 384 def UpdateDescriptionFromIssue(self):
385 """Updates self.description with the issue description from Rietveld.""" 385 """Updates self.description with the issue description from Rietveld."""
386 self._desc = git_cl.ChangeDescription( 386 self._desc = git_cl.ChangeDescription(
387 self.SendToRietveld('/%d/description' % self.issue)) 387 self.SendToRietveld('/%d/description' % self.issue))
388 388
389 def GetApprovingReviewers(self): 389 def GetApprovingReviewers(self):
390 """Returns the issue reviewers list from Rietveld.""" 390 """Returns the issue reviewers list from Rietveld."""
391 return git_cl.get_approving_reviewers( 391 return git_cl.get_approving_reviewers(
392 self.rietveld.get_issue_properties(self.issue, False)) 392 self.RpcServer().get_issue_properties(self.issue, False))
393 393
394 def AddComment(self, comment): 394 def AddComment(self, comment):
395 """Adds a comment for an issue on Rietveld. 395 """Adds a comment for an issue on Rietveld.
396 As a side effect, this will email everyone associated with the issue.""" 396 As a side effect, this will email everyone associated with the issue."""
397 return self.RpcServer().add_comment(self.issue, comment) 397 return self.RpcServer().add_comment(self.issue, comment)
398 398
399 def PrimeLint(self): 399 def PrimeLint(self):
400 """Do background work on Rietveld to lint the file so that the results are 400 """Do background work on Rietveld to lint the file so that the results are
401 ready when the issue is viewed.""" 401 ready when the issue is viewed."""
402 if self.issue and self.patchset: 402 if self.issue and self.patchset:
(...skipping 1064 matching lines...) Expand 10 before | Expand all | Expand 10 after
1467 raise 1467 raise
1468 print >> sys.stderr, ( 1468 print >> sys.stderr, (
1469 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith ' 1469 'AppEngine is misbehaving and returned HTTP %d, again. Keep faith '
1470 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e)) 1470 'and retry or visit go/isgaeup.\n%s') % (e.code, str(e))
1471 return 1 1471 return 1
1472 1472
1473 1473
1474 if __name__ == "__main__": 1474 if __name__ == "__main__":
1475 fix_encoding.fix_encoding() 1475 fix_encoding.fix_encoding()
1476 sys.exit(main(sys.argv[1:])) 1476 sys.exit(main(sys.argv[1:]))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698