[chromedriver] Clean tmp directory and kill Chrome processes before each run cycle.

[chromedriver] Clean tmp directory and kill Chrome processes before each run cycle.

Also enable some passed java tests.

BUG=none
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197220

[chrisgao (Use stgao instead), 2013-04-27 00:48:43]

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
File chrome/test/chromedriver/run_all_tests.py (right):

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:100: util.RunCommand(['pkill', '-9',
os.path.basename(chrome_path)])
Is there a way to kill the chrome processes based on the path to the chrome
binary?
When based on name, chrome started with binary in another path will also be
killed. This is bad for testing locally.

[craigdh, 2013-04-29 17:31:40]

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
File chrome/test/chromedriver/run_all_tests.py (right):

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:100: util.RunCommand(['pkill', '-9',
os.path.basename(chrome_path)])
On 2013/04/27 00:48:43, chrisgao wrote:
> Is there a way to kill the chrome processes based on the path to the chrome
> binary?
> When based on name, chrome started with binary in another path will also be
> killed. This is bad for testing locally.

This also doesn't work on Android, for obvious reasons. It's not a very big deal
as adb_commands.py restarts chrome anyway.

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:166: atexit.register(CleanTmpDir)
It would be more pythonic to have a try/finally block and put this in the
finally.

[kkania, 2013-04-29 18:25:43]

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
File chrome/test/chromedriver/run_all_tests.py (right):

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:96: def KillChromes(chrome_path):
i think it would make more sense to put all this in the run_buildbot_steps.py
script, which is only intended to be run on the bots

[chrisgao (Use stgao instead), 2013-04-29 22:10:26]

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
File chrome/test/chromedriver/run_all_tests.py (right):

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:96: def KillChromes(chrome_path):
On 2013/04/29 18:25:43, kkania wrote:
> i think it would make more sense to put all this in the run_buildbot_steps.py
> script, which is only intended to be run on the bots

Done.

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:100: util.RunCommand(['pkill', '-9',
os.path.basename(chrome_path)])
On 2013/04/29 17:31:40, craigdh wrote:
> On 2013/04/27 00:48:43, chrisgao wrote:
> > Is there a way to kill the chrome processes based on the path to the chrome
> > binary?
> > When based on name, chrome started with binary in another path will also be
> > killed. This is bad for testing locally.
> 
> This also doesn't work on Android, for obvious reasons. It's not a very big
deal
> as adb_commands.py restarts chrome anyway.

Right, let us just ignore Android.

https://chromiumcodereview.appspot.com/14301024/diff/10006/chrome/test/chrome...
chrome/test/chromedriver/run_all_tests.py:166: atexit.register(CleanTmpDir)
On 2013/04/29 17:31:40, craigdh wrote:
> It would be more pythonic to have a try/finally block and put this in the
> finally.

Done.

[kkania, 2013-04-29 22:54:30]

lgtm

https://codereview.chromium.org/14301024/diff/21001/chrome/test/chromedriver/...
File chrome/test/chromedriver/run_buildbot_steps.py (right):

https://codereview.chromium.org/14301024/diff/21001/chrome/test/chromedriver/...
chrome/test/chromedriver/run_buildbot_steps.py:149: tmp_dir =
os.path.dirname(util.MakeTempDir())
tempfile.gettempdir()

[craigdh, 2013-04-29 22:59:53]

lgtm after ken's comment is addressed.

[chrisgao (Use stgao instead), 2013-04-30 00:55:28]

https://codereview.chromium.org/14301024/diff/21001/chrome/test/chromedriver/...
File chrome/test/chromedriver/run_buildbot_steps.py (right):

https://codereview.chromium.org/14301024/diff/21001/chrome/test/chromedriver/...
chrome/test/chromedriver/run_buildbot_steps.py:149: tmp_dir =
os.path.dirname(util.MakeTempDir())
On 2013/04/29 22:54:30, kkania wrote:
> tempfile.gettempdir()

Done.

[commit-bot: I haz the power, 2013-04-30 00:57:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/chrisgao@chromium.org/14301024/28002

[commit-bot: I haz the power, 2013-04-30 01:47:20]

Change committed as 197220