Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Side by Side Diff: cc/resources/scoped_resource.cc

Issue 14301021: cc: Don't pass simple well-defined classes by reference. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « cc/resources/scoped_resource.h ('k') | cc/resources/tile.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/resources/scoped_resource.h" 5 #include "cc/resources/scoped_resource.h"
6 6
7 namespace cc { 7 namespace cc {
8 8
9 ScopedResource::ScopedResource(ResourceProvider* resource_provider) 9 ScopedResource::ScopedResource(ResourceProvider* resource_provider)
10 : resource_provider_(resource_provider) { 10 : resource_provider_(resource_provider) {
11 DCHECK(resource_provider_); 11 DCHECK(resource_provider_);
12 } 12 }
13 13
14 ScopedResource::~ScopedResource() { 14 ScopedResource::~ScopedResource() {
15 Free(); 15 Free();
16 } 16 }
17 17
18 bool ScopedResource::Allocate(const gfx::Size& size, GLenum format, 18 bool ScopedResource::Allocate(gfx::Size size,
19 GLenum format,
19 ResourceProvider::TextureUsageHint hint) { 20 ResourceProvider::TextureUsageHint hint) {
20 DCHECK(!id()); 21 DCHECK(!id());
21 DCHECK(!size.IsEmpty()); 22 DCHECK(!size.IsEmpty());
22 23
23 set_dimensions(size, format); 24 set_dimensions(size, format);
24 set_id(resource_provider_->CreateResource(size, format, hint)); 25 set_id(resource_provider_->CreateResource(size, format, hint));
25 26
26 #ifndef NDEBUG 27 #ifndef NDEBUG
27 allocate_thread_id_ = base::PlatformThread::CurrentId(); 28 allocate_thread_id_ = base::PlatformThread::CurrentId();
28 #endif 29 #endif
29 30
30 return id() != 0; 31 return id() != 0;
31 } 32 }
32 33
33 void ScopedResource::Free() { 34 void ScopedResource::Free() {
34 if (id()) { 35 if (id()) {
35 #ifndef NDEBUG 36 #ifndef NDEBUG
36 DCHECK(allocate_thread_id_ == base::PlatformThread::CurrentId()); 37 DCHECK(allocate_thread_id_ == base::PlatformThread::CurrentId());
37 #endif 38 #endif
38 resource_provider_->DeleteResource(id()); 39 resource_provider_->DeleteResource(id());
39 } 40 }
40 set_id(0); 41 set_id(0);
41 } 42 }
42 43
43 void ScopedResource::Leak() { 44 void ScopedResource::Leak() {
44 set_id(0); 45 set_id(0);
45 } 46 }
46 47
47 } // namespace cc 48 } // namespace cc
OLDNEW
« no previous file with comments | « cc/resources/scoped_resource.h ('k') | cc/resources/tile.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698