Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14301021: cc: Don't pass simple well-defined classes by reference. (Closed)

Created:
7 years, 8 months ago by danakj
Modified:
7 years, 8 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, backer, piman
Visibility:
Public.

Description

cc: Don't pass simple well-defined classes by reference. Style-only change to match the rule being added in CL https://codereview.chromium.org/14410002/ . R=enne BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -103 lines) Patch
M cc/layers/layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/shader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/output/shader.cc View 3 chunks +34 lines, -34 lines 0 comments Download
M cc/quads/shared_quad_state.h View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/quads/shared_quad_state.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/picture.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_layer_tiling.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile_base.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture_pile_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/resource.h View 1 chunk +6 lines, -3 lines 0 comments Download
M cc/resources/resource.cc View 2 chunks +1 line, -6 lines 0 comments Download
M cc/resources/resource_pool.h View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/resource_pool.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/scoped_resource.h View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/resources/scoped_resource.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/tile.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_pile_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_tree_test.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/layer_tree_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_occlusion.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M cc/trees/proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/thread_proxy.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/thread_proxy.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
danakj
7 years, 8 months ago (2013-04-23 02:09:36 UTC) #1
enne (OOO)
lgtm
7 years, 8 months ago (2013-04-23 02:12:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/14301021/1
7 years, 8 months ago (2013-04-23 02:14:19 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-23 05:36:30 UTC) #4
Message was sent while issue was closed. 
Change committed as 195726

Powered by Google App Engine
This is Rietveld 408576698