chrome/test/data/extensions/api_test/messaging/connect/page.js - Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/messaging/connect/page.js

Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: add key to app1/manifest.json Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/resources/extensions/test_custom_bindings.js ('k') | chrome/test/data/extensions/api_test/messaging/connect/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/messaging/connect/page.js

diff --git a/chrome/test/data/extensions/api_test/messaging/connect/page.js b/chrome/test/data/extensions/api_test/messaging/connect/page.js

index 7d141f6642e752e991e324e17b67d72fdaee53cb..1e3a7e8eb3dcc68b0c9b3f2f7ba8204ef1819a7a 100644

--- a/chrome/test/data/extensions/api_test/messaging/connect/page.js

+++ b/chrome/test/data/extensions/api_test/messaging/connect/page.js

@@ -85,5 +85,6 @@ function testConnectFromTabError() {

// For test sendMessage.

chrome.runtime.onMessage.addListener(function(request, sender, sendResponse) {

+ chrome.test.assertEq({id: chrome.runtime.id}, sender);

sendResponse({success: (request.step2 == 1)});

});