Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/extensions/api/messaging/extension_message_port.cc

Issue 14301016: Fix a couple of bugs relating to sending Tab info with chrome.runtime.connect and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: add key to app1/manifest.json Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/extension_message_port.cc
diff --git a/chrome/browser/extensions/api/messaging/extension_message_port.cc b/chrome/browser/extensions/api/messaging/extension_message_port.cc
index f1510efd099ed070f8bc4339a628448ced79e0e6..e4782c74f2d246165a5fe5d132c8cd76e3bb6d33 100644
--- a/chrome/browser/extensions/api/messaging/extension_message_port.cc
+++ b/chrome/browser/extensions/api/messaging/extension_message_port.cc
@@ -26,12 +26,16 @@ ExtensionMessagePort::ExtensionMessagePort(content::RenderProcessHost* process,
void ExtensionMessagePort::DispatchOnConnect(
int dest_port_id,
const std::string& channel_name,
- const std::string& tab_json,
+ const base::DictionaryValue& source_tab,
const std::string& source_extension_id,
- const std::string& target_extension_id) {
+ const std::string& target_extension_id,
+ const GURL& source_url) {
+ ExtensionMsg_ExternalConnectionInfo info;
+ info.target_id = target_extension_id;
+ info.source_id = source_extension_id;
+ info.source_url = source_url;
process_->Send(new ExtensionMsg_DispatchOnConnect(
- routing_id_, dest_port_id, channel_name,
- tab_json, source_extension_id, target_extension_id));
+ routing_id_, dest_port_id, channel_name, source_tab, info));
}
void ExtensionMessagePort::DispatchOnDisconnect(

Powered by Google App Engine
This is Rietveld 408576698