ui/gl/gl_surface_glx.cc - Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gl/gl_surface_glx.cc

Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove checks for death with correct error, which seem to fail on iOS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gl/gl_surface_glx.cc

diff --git a/ui/gl/gl_surface_glx.cc b/ui/gl/gl_surface_glx.cc

index 87dffe9e5ba8f450c9ebcafc2fb43319096cdcf8..b2f9cf99f0e9fcfd0201886773e22c9c40f7a916 100644

--- a/ui/gl/gl_surface_glx.cc

+++ b/ui/gl/gl_surface_glx.cc

@@ -240,9 +240,6 @@ class SGIVideoSyncVSyncProvider

shim_((new SGIVideoSyncProviderThreadShim(window))->AsWeakPtr()),

cancel_vsync_flag_(shim_->cancel_vsync_flag()),

vsync_lock_(shim_->vsync_lock()) {

- // The WeakPtr is bound to the SGIVideoSyncThread. We only use it for

- // PostTask.

- shim_->DetachFromThread();

vsync_thread_->message_loop()->PostTask(

FROM_HERE,

base::Bind(&SGIVideoSyncProviderThreadShim::Initialize, shim_));