chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc - Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

Issue 14299011: Remove all but one use of WeakPtrFactory::DetachFromThread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Remove checks for death with correct error, which seem to fail on iOS Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

diff --git a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

index 1f9e7f5484a09304603446937ab8de1ee8077545..22f8845a6159dfd98d7ad0bc116c6ed9e9b39120 100644

--- a/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

+++ b/chrome/browser/extensions/api/declarative/rules_registry_with_cache.cc

@@ -97,9 +97,6 @@ RulesRegistryWithCache::RulesRegistryWithCache(

ui_part->reset(storage_on_ui_.get());

- // After construction, |this| continues to live only on |owner_thread|.

- weak_ptr_factory_.DetachFromThread();

storage_on_ui_->Init();

}

« no previous file with comments | « base/memory/weak_ptr_unittest.cc ('k') | chrome/browser/io_thread.cc » ('j') | no next file with comments »