Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 14296009: Inline String.fromCharCode in hydrogen. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 8 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Inline String.fromCharCode in hydrogen. BUG= Committed: https://code.google.com/p/v8/source/detail?r=14315

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -5 lines) Patch
M src/hydrogen.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 1 chunk +3 lines, -5 lines 0 comments Download
M test/mjsunit/string-fromcharcode.js View 1 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
lgtm with comments https://codereview.chromium.org/14296009/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/14296009/diff/1/src/hydrogen.cc#newcode8552 src/hydrogen.cc:8552: printf("cool\n"); Please remove. https://codereview.chromium.org/14296009/diff/1/src/runtime.cc File src/runtime.cc ...
7 years, 8 months ago (2013-04-16 22:19:30 UTC) #1
Yang
7 years, 8 months ago (2013-04-17 16:37:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r14315 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698